-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto Changelog #1373
Auto Changelog #1373
Conversation
Removed last nodejitsu reference
@jcrugzz @indexzero If one of you guys can sign off on this, we can go ahead and get this merged, cut a release, and then I'll work on getting some of the other PRs reviewed & merged to master. |
@jsmylnycky I think this looks reasonable. @indexzero is on vacation so lets give him a day to see if he pops on here, otherwise ill merge. Thanks for this! |
@jcrugzz @indexzero /poke :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haven't used auto-changelog
, but it's certainly a nice thing to automate 👍
Merging, feel free to cut a release when you're ready! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
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
I have note used auto-changelog before, but it seems pretty useful and the formatting it performed looked about as good as one could hope. If you would prefer a different format, just let me know and I'll be happy to change it :) It should be wired up to automatically rebuild the changelog with the correct package.json version whenever
npm version
is ran.I also went through all of the most recent merges into Master and everything looked pretty good to me. The only things I caught were the nodejitsu reference, and I updated the engines block in package.json to conform to the travis-ci Node environments.