Version 8.2.0, fix selectors processing issue

CHANGELOG.md

@@ -1,5 +1,9 @@
 # Changelog
 
+## Version 8.2.0
+
+Fix for the issue [#249](https://github.com/html-to-text/node-html-to-text/issues/249) and possibly other obscure issues when some selector options are ignored. `options.selectors` array was not fully processed before.
+
 ## Version 8.1.1
 
 Bump `minimist` dependency, regenerate `package-lock.json`.

lib/html-to-text.js

@@ -144,19 +144,19 @@ function compile (options = {}) {
     }
   );
   options.formatters = Object.assign({}, defaultFormatters, options.formatters);
+  options.selectors = mergeDuplicatesPreferLast(options.selectors, (s => s.selector));
 
   handleDeprecatedOptions(options);
 
-  const uniqueSelectors = mergeDuplicatesPreferLast(options.selectors, (s => s.selector));
-  const selectorsWithoutFormat = uniqueSelectors.filter(s => !s.format);
+  const selectorsWithoutFormat = options.selectors.filter(s => !s.format);
   if (selectorsWithoutFormat.length) {
     throw new Error(
       'Following selectors have no specified format: ' +
       selectorsWithoutFormat.map(s => `\`${s.selector}\``).join(', ')
     );
   }
   const picker = new selderee.DecisionTree(
-    uniqueSelectors.map(s => [s.selector, s])
+    options.selectors.map(s => [s.selector, s])
   ).build(hp2Builder);
 
   const baseSelectorsPicker = new selderee.DecisionTree(

package.json

@@ -1,6 +1,6 @@
 {
   "name": "html-to-text",
-  "version": "8.1.1",
+  "version": "8.2.0",
   "description": "Advanced html to plain text converter",
   "license": "MIT",
   "author": {

test/tags.js

@@ -271,6 +271,17 @@ describe('tags', function () {
       expect(htmlToText(html)).to.equal(expected);
     });
 
+    it('should return link without brackets if noLinkBrackets is set to true (deprecated option)', function () {
+      const html = '<a href="http://my.link">test</a>';
+      const expected = 'test http://my.link';
+      const options = {
+        selectors: [
+          { selector: 'a', options: { noLinkBrackets: true } }
+        ]
+      };
+      expect(htmlToText(html, options)).to.equal(expected);
+    });
+
     it('should return link without brackets if linkBrackets is set to false', function () {
       const html = '<a href="http://my.link">test</a>';
       const expected = 'test http://my.link';