Support displaying from an offset in a framebuf #6245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not sure why you'd do this, maybe to simultaneously render? Should help the Silent Hill games which seem to do this.
|
Fixes flickering of Silent Hill Zero and #6238 |
Should fix hrydgard#5343 based on stack trace.
|
With all this framebuffer searching and things like the strange uses of blockcopy offsets in Grand Knights History and texturing outside buffers in Breath of Fire, I'm starting to think that we should create some kind of map of VRAM with our beliefs of what buffers are where. Technically our lists of framebuffers and textures already form that map, but you know, a little more explicitly. Anyhow, seems fine. |
hrydgard
added a commit
that referenced
this pull request
Jun 7, 2014
Support displaying from an offset in a framebuf
|
I think really the most important is just the framebuffers. Textures are important only for invalidation, but we scan them all the time now (by default) anyway. -[Unknown] |
This was referenced Jun 7, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems like this is what Silent Hill is doing, I think. Got some confirmation that this fixes at least one of the Silent Hill games.
Also, be a bit more careful with framebuffers that don't match the display format, mostly for videos, after having relaxed the format check.
-[Unknown]