Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix __KernelUmdActivate() #5277

Closed
wants to merge 2 commits into from
Closed

Fix __KernelUmdActivate() #5277

wants to merge 2 commits into from

Conversation

dbz400
Copy link
Contributor

@dbz400 dbz400 commented Jan 30, 2014

When sceKernelGetCompiledSdkVersion() != 0 , sdkVersion set and PSP_UMD_READY will be |= to notifyArg and return as 0x32 instead of 0x22 .

Fixes #4969 & #4546

Thanks @daniel229 for finding out this fix.

@@ -15,6 +15,8 @@
// Official git repository and contact information can be found at
// https://github.com/hrydgard/ppsspp and http://www.ppsspp.org/.

extern int sdkVersion_;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In other places, sceKernelGetCompiledSdkVersion() is used, instead of externing. Anyway, this extern is in the wrong place, and since it's suffixed by an underscore just looks wrong.

I still think it's probably a good idea to do some actual tests.

-[Unknown]

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done .

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have "return as 0x32 as real PSP do". Does that mean you did tests with a real PSP? I notice the other one doesn't say that a real PSP does that, even though I'm pretty sure that one is confirmed to be done by a real PSP. The comments seem confusing.

-[Unknown]

@unknownbrackets
Copy link
Collaborator

I'm not sure the "// return as 0x22" comments are useful, but I did do a test and the behavior here does differ by sdk version, even for "1". I found a different bug meanwhile, and other behavior that differs by sdk version.

-[Unknown]

@dbz400
Copy link
Contributor Author

dbz400 commented Jan 31, 2014

Alright .I removed the comment .

@dbz400
Copy link
Contributor Author

dbz400 commented Feb 2, 2014

Not too sure if this going to merge though it did fix #4969 & #4546, referencing JPCSP there by their PSP test

https://code.google.com/p/jpcsp/source/browse/trunk/src/jpcsp/HLE/modules150/sceUmdUser.java#214

    if (iso != null) {
            notifyArg = PSP_UMD_PRESENT | PSP_UMD_READABLE;
            // The PSP is returning 0x32 instead of 0x22 when
            //     sceKernelSetCompiledSdkVersion()
            // has been called (i.e. when sceKernelGetCompiledSdkVersion() != 0).
            if (Modules.SysMemUserForUserModule.hleKernelGetCompiledSdkVersion() != 0) {
                    notifyArg |= PSP_UMD_READY;
            }

@unknownbrackets
Copy link
Collaborator

This does seem to happen but may need to be rebased after all.

-[Unknown]

@dbz400
Copy link
Contributor Author

dbz400 commented Feb 2, 2014

I purged my old reposityory and cannot rebase .Will do a pull .

@dbz400 dbz400 closed this Feb 2, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Arcana Famiglia Vascello Fantasma hangs up on logo screen
2 participants