Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some video -> framebuffer issues #4321

Merged
merged 2 commits into from
Oct 26, 2013

Conversation

unknownbrackets
Copy link
Collaborator

This kills some of the flicker and size problems with videos, and even a missing video (#3771, #4273.)

It's still not perfect. As noted in #4270 (comment), some games don't use the fbo for both video frames. The result is that some filtering is slightly different, so you see very slight artifacts. The effect of this reduces at higher rendering resolutions (or did for me anyway.)

Anyway, this is a lot better already. That said, I could use testing on more games (@solarmystic, wanna test a few?)

-[Unknown]

Fixes hrydgard#3771, video frames being drawn at the wrong size at non-1x.
But only when coming from a video or other safe source, to ensure we don't
hurt speed.  Although, might be interesting to do it always?

With the previous commit, fixes hrydgard#4273.
@daniel229
Copy link
Collaborator

Fixed video render at that render resolution : windows size not 1:1 like God of War,Super Robot Taisen OE.
03

@danyalziakhan
Copy link
Contributor

@unknownbrackets your commit slightly improves the intro video playback in MGS:Portable Ops. Now, it doesn't change viewport at non-1x resolution at 1x window size, However, it still flickers (changes viewport) at Full Screen (or non-1x window size) at non-1x resolution.

Another improvement is that now the video plays okay (by okay I mean the effect is same as I described above without shader) without showing black screen with "Scanlines (CRT)" shader that are being drawn at "Output Resolution".

@unknownbrackets
Copy link
Collaborator Author

Hmm, it fixed other games that had viewport issues at non-1x, that's odd. Is the video in the bottom left corner of the window, or too big in these scenarios?

-[Unknown]

@danyalziakhan
Copy link
Contributor

It's neither small nor too big. At Full screen with 2x Internal resolution, the video flickers and the viewport squashes a bit. Not sure if the screenshot can help:- (taken through Print Screen)
untitled

@solarmystic and @thedax can confirm this, I guess.

@solarmystic
Copy link
Contributor

@unknownbrackets

Will do the usual tests and report back later, with the usual tables etc.

@solarmystic
Copy link
Contributor

@unknownbrackets @hrydgard

Test results:

capture

Major Observations:

  1. Mostly nothing worthy of note in my list. Which is good, as all the games in that list had no prior flickering issues reported in the current master (no regressions from master). With the exception of Tekken 5 (see below)
  2. Tekken 5 Dark Resurrection has never displayed its opening FMV before in any previous master, which I noted in the list. No regression there.
  3. However, as per @DanyalZia's suggestion, testing MGS Portable Ops (not in the test suite, but I have the game) yields comparable results as he outlined above. MGS Peace Walker is obviously not afflicted with same issue, as already noted in my list.

Conclusion:
This commit does not negatively affect any game in the test suite with regards to FMV playback/graphics and is thus safe for merging at least for the games in my list.

@unknownbrackets
Copy link
Collaborator Author

Cool, thanks for testing. I wonder what's up with Tekken 5.

Hmm, maybe something still isn't being reset for Metal Gear Solid...

-[Unknown]

hrydgard added a commit that referenced this pull request Oct 26, 2013
Fix some video -> framebuffer issues
@hrydgard hrydgard merged commit 1fa5718 into hrydgard:master Oct 26, 2013
@unknownbrackets unknownbrackets deleted the fbo-minor branch October 26, 2013 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants