-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix some video -> framebuffer issues #4321
Conversation
Fixes hrydgard#3771, video frames being drawn at the wrong size at non-1x.
But only when coming from a video or other safe source, to ensure we don't hurt speed. Although, might be interesting to do it always? With the previous commit, fixes hrydgard#4273.
@unknownbrackets your commit slightly improves the intro video playback in MGS:Portable Ops. Now, it doesn't change viewport at non-1x resolution at 1x window size, However, it still flickers (changes viewport) at Full Screen (or non-1x window size) at non-1x resolution. Another improvement is that now the video plays okay (by okay I mean the effect is same as I described above without shader) without showing black screen with "Scanlines (CRT)" shader that are being drawn at "Output Resolution". |
Hmm, it fixed other games that had viewport issues at non-1x, that's odd. Is the video in the bottom left corner of the window, or too big in these scenarios? -[Unknown] |
It's neither small nor too big. At Full screen with 2x Internal resolution, the video flickers and the viewport squashes a bit. Not sure if the screenshot can help:- (taken through Print Screen) @solarmystic and @thedax can confirm this, I guess. |
Will do the usual tests and report back later, with the usual tables etc. |
Test results: Major Observations:
Conclusion: |
Cool, thanks for testing. I wonder what's up with Tekken 5. Hmm, maybe something still isn't being reset for Metal Gear Solid... -[Unknown] |
Fix some video -> framebuffer issues
This kills some of the flicker and size problems with videos, and even a missing video (#3771, #4273.)
It's still not perfect. As noted in #4270 (comment), some games don't use the fbo for both video frames. The result is that some filtering is slightly different, so you see very slight artifacts. The effect of this reduces at higher rendering resolutions (or did for me anyway.)
Anyway, this is a lot better already. That said, I could use testing on more games (@solarmystic, wanna test a few?)
-[Unknown]