softgpu: Correct tex on fogged rectangles #16384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the fog factor would result in the same amount of fog, we're just adding more work for no reason.
|
Truly weird stuff, there seem to be no end to wacky edge cases :) nice fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using fog on a rectangle (transform only), the PSP does this weird snap-to effect that seems like some sort of hardware bug to me. Half the rectangle uses the first vertex fog value - and it's the second half, weirdly.
Anyway, I had implemented that earlier based on hardware fog tests, but forgot to account or test for texture coordinates. This caused smoke in Resistance Retribution (see #16131) to be rendered strangely.
Meanwhile, I also made it skip splitting rectangles in half to account for this weird fog behavior when the fog factors are close enough to be identical for the purposes of fogging. This avoids the split path entirely in Resistance (and would've fixed the bug alone, but good to fix texturing in that path anyway.)
-[Unknown]