softjit: Fix dst blend shift #16132
Merged
softjit: Fix dst blend shift #16132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this, it's possible we might not notice or apply a change whether in uniforms or etc.
Several games appear to intentionally set the matrix flat.
Example: src * dst.a + dst * one, still requires a shift back.
|
Nice catches with the dirtying. Hm, surprised that no-op texture projection is common, we could optimize that in the hardware renderer too. Although it's not exactly expensive so probably won't make much difference... |
hrydgard
approved these changes
Sep 30, 2022
In fact, it already is (see -[Unknown] |
|
Oh duh. Right :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Silly mistake in a recent change, fixes the ocean in #16131.
Also, while I was looking at it I optimized a case of
0, 0, 0, 1matrix values for q a bit. While so doing, I realized we don't actually dirty matrix uniforms ingstate.Restore(). Initially I went to change this to setting cmds for shared dirty handling, but I figured it's safer to just dirty in ResetMatrices() due to currentList access.Also noticed that tgen wasn't properly dirtying the fragment shader ID, so this also fixes that.
Not sure how many games use the save/restore of contexts for matrix state, but better to be safe.
-[Unknown]