SQUASHME -- fixes for the things Jeff noted in the review, and a few more things #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
more things. I still have not re-read all of README (the changes there are based on what Howard changed, and also some global search-n-replaces). Signed-off-by: Jeff Squyres <jsquyres@cisco.com>
hppritcha
pushed a commit
that referenced
this pull request
Jul 12, 2017
README: minor tweak to specifically mention GNU Fortran
hppritcha
pushed a commit
that referenced
this pull request
Sep 5, 2019
fix fortran problems with sessions
hppritcha
pushed a commit
that referenced
this pull request
Feb 26, 2020
This commit addresses two issues in osc/rdma:
1) It is erroneous to attach regions that overlap. This was being
allowed but the standard does not allow overlapping attachments.
2) Overlapping registration regions (4k alignment of attachments)
appear to be allowed. Add attachment bases to the bookeeping
structure so we can keep better track of what can be detached.
It is possible that the standard did not intend to allow #2. If that
is the case then #2 should fail in the same way as #1. There should
be no technical reason to disallow #2 at this time.
References open-mpi#7384
Signed-off-by: Nathan Hjelm <hjelmn@google.com>
hppritcha
pushed a commit
that referenced
this pull request
Apr 7, 2020
This commit addresses two issues in osc/rdma:
1) It is erroneous to attach regions that overlap. This was being
allowed but the standard does not allow overlapping attachments.
2) Overlapping registration regions (4k alignment of attachments)
appear to be allowed. Add attachment bases to the bookeeping
structure so we can keep better track of what can be detached.
It is possible that the standard did not intend to allow #2. If that
is the case then #2 should fail in the same way as #1. There should
be no technical reason to disallow #2 at this time.
References open-mpi#7384
Signed-off-by: Nathan Hjelm <hjelmn@google.com>
(cherry picked from commit 6649aef)
Signed-off-by: Nathan Hjelm <hjelmn@google.com>
hppritcha
pushed a commit
that referenced
this pull request
Dec 7, 2024
…rrte-config-option Refactored the --with-prrte configure option to reject building Open MPI against external installs of PRRTE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I still have not re-read all of README (the changes there are based on
what Howard changed, and also some global search-n-replaces).
For open-mpi#3058.
Signed-off-by: Jeff Squyres jsquyres@cisco.com