Skip to content

Commit

Permalink
temporarily disable fboxes for sessions
Browse files Browse the repository at this point in the history
the way fboxes works has issues for the sessions implementation,
in particular tthe session finalize approach.

what happens without this temporary fix is that if there is not some fully shcnronizing call
prior to calling session_finalize, there are cases where a process may be probing its fast
mailboxes for processes that are tearing down theses fboxes.  That results in segfauls and
sigbus problems.

The fast box mechanism will need to be supplemented with some kind of shutdown mechanism
that will tell the owner of the fboxes when its okay to actually tear them down.

IN the interest of making progress using the sessions prototype with applications, shut
down the fbox process for the prototype and return to coming up with a real fix at a later
date.

relates to #3

Signed-off-by: Howard Pritchard <hppritcha@gmail.com>
  • Loading branch information
hppritcha committed May 11, 2020
1 parent 4b278cf commit 0f3b44c
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion opal/mca/btl/sm/btl_sm_fifo.h
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,9 @@ static inline bool sm_fifo_write_ep (mca_btl_sm_hdr_t *hdr, struct mca_btl_base_
opal_atomic_wmb ();
return mca_btl_sm_fbox_sendi (ep, 0xfe, &rhdr, sizeof (rhdr), NULL, 0);
}
mca_btl_sm_try_fbox_setup (ep, hdr);
#if 0
mca_btl_smr_try_fbox_setup (ep, hdr);
#endif
hdr->next = SM_FIFO_FREE;
sm_fifo_write (ep->fifo, rhdr);

Expand Down

0 comments on commit 0f3b44c

Please sign in to comment.