Fix Pharo12 builds failing due to removal of Time>>millisecondsToRun:
#624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
January 14, 2024 09:36
…w subclasses to override it
…malltalkCI when sending `timeToRun:`
…s receiver instead of `SmalltalkCI`
|
Ok, I removed metadata also from non-Pharo-specific packages and the builds require very old versions of Pharo to still work. I will re-create this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pharo12 builds started failing (see issue #623).
Changes in this PR fix this issue as shown in build https://github.com/SeasideSt/Grease/actions/runs/7518132269/job/20465637446
that uses the fork of this PR.
While making these changes, I also encountered a load dependency failure due to a class for the code coverage implementation in Pharo that was in the Core package rather than the Coverage package.
I also notice that because of the use of Iceberg, the (obsolete) monticello metadata has been removed. This should be fine especially for Pharo but let me know if you want things to be different.