Zoom und Scrollbars #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
TODO:
Currently known issues:
|
ClFeSc
requested changes
Jun 26, 2021
...ages/SketchMorph2-Tests.package/MorphicMonetTests.class/instance/testIsWindowColorCorrect.st
Outdated
Show resolved
Hide resolved
ClFeSc
requested changes
Jun 26, 2021
packages/SketchMorph2-Core.package/M2Canvas.class/instance/isControlKeyEvent..st
Outdated
Show resolved
Hide resolved
packages/SketchMorph2-Core.package/M2CheckBoxMenuItem.class/class/valueSelector.st
Outdated
Show resolved
Hide resolved
packages/SketchMorph2-Core.package/M2DrawingContext.class/instance/isInAnyDrawingMode.st
Outdated
Show resolved
Hide resolved
packages/SketchMorph2-Core.package/M2ViewPort.class/instance/formExtent.st
Outdated
Show resolved
Hide resolved
ClFeSc
approved these changes
Jun 26, 2021
maximilian-franz
requested changes
Jun 26, 2021
Comment on lines
+2
to
+3
| brushSize: anObject | ||
| self context brushSize: anObject |
There was a problem hiding this comment.
Suggested change
| brushSize: anObject | |
| self context brushSize: anObject | |
| brushSize: aNumber | |
| self context brushSize: aNumber |
There was a problem hiding this comment.
We decided not to write the variable type in methods in the delegation category since these methods are only supposed to pass the method call to the context without having knowledge of the type of data they are receiving.
Comment on lines
+2
to
+3
| self context currentGeometricForm: anObject |
There was a problem hiding this comment.
Suggested change
| currentGeometricForm: anObject | |
| self context currentGeometricForm: anObject | |
| currentGeometricForm: aSymbol | |
| self context currentGeometricForm: aSymbol |
There was a problem hiding this comment.
We decided not to write the variable type in methods in the delegation category since these methods are only supposed to pass the method call to the context without having knowledge of the type of data they are receiving.
Comment on lines
+2
to
+3
| self context isErasing: anObject |
There was a problem hiding this comment.
Suggested change
| isErasing: anObject | |
| self context isErasing: anObject | |
| isErasing: aBoolean | |
| self context isErasing: aBoolean |
Comment on lines
+2
to
+3
| self context isFillingGeometricForm: anObject |
There was a problem hiding this comment.
Suggested change
| isFillingGeometricForm: anObject | |
| self context isFillingGeometricForm: anObject | |
| isFillingGeometricForm: aBoolean | |
| self context isFillingGeometricForm: aBoolean |
Comment on lines
+2
to
+3
| self context mode: anObject |
There was a problem hiding this comment.
Suggested change
| mode: anObject | |
| self context mode: anObject | |
| mode: aSymbol | |
| self context mode: aSymbol |
packages/SketchMorph2-Core.package/M2ViewPort.class/instance/userActionStopDrawing.st
Outdated
Show resolved
Hide resolved
packages/SketchMorph2-Core.package/MorphicMonet.class/instance/loadCanvas.st
Outdated
Show resolved
Hide resolved
packages/SketchMorph2-Core.package/MorphicMonet.class/instance/minimumExtent.st
Show resolved
Hide resolved
...s/SketchMorph2-Tests.package/M2DrawingComponentTests.class/instance/assertEqualityOf.and..st
Outdated
Show resolved
Hide resolved
packages/SketchMorph2-Tests.package/MorphicMonetTests.class/instance/doDummyAction.st
Outdated
Show resolved
Hide resolved
johannes-poetzsch
approved these changes
Jun 26, 2021
ClFeSc
reviewed
Jun 27, 2021
...s/SketchMorph2-Tests.package/M2DrawingComponentTests.class/instance/assertEqualityOf.and..st
Outdated
Show resolved
Hide resolved
Co-authored-by: Maximilian Franz <maximilian.franz@student.hpi.de>
| @@ -1,5 +1,5 @@ | |||
| undo | |||
| userActionClickAt: aPoint | |||
| (self isInTextMode or: [self isInEditingTextMode]) | |||
| ifFalse: [self createUserActionWithStart: aPoint]. | |||
| self context isInAnyDrawingMode | |||
There was a problem hiding this comment.
This is unnecessary since the viewport always checks this condition before calling the method.
There was a problem hiding this comment.
This should also apply to similar methods like M2Backend>>userActionStopDrawing.
maximilian-franz
approved these changes
Jun 28, 2021
This was referenced Jun 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #85
Closes #1