-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add text tool #64
Add text tool #64
Conversation
The test |
Without having looked at the code yet, |
I don't know if it's just me but, in comparison to other branches, something is affecting the performance while drawing. Might be something to take a closer look at. |
4efe986
to
6b7900e
Compare
Pull Request Test Coverage Report for Build 900165383Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
We currently have the problem that, when moving MorphicMonet, one can see the |
packages/SketchMorph2-Core.package/M2Backend.class/instance/isInEditingTextMode.st
Outdated
Show resolved
Hide resolved
packages/SketchMorph2-Core.package/M2Backend.class/instance/isInPenMode.st
Outdated
Show resolved
Hide resolved
packages/SketchMorph2-Core.package/M2Backend.class/instance/isInTextMode.st
Outdated
Show resolved
Hide resolved
packages/SketchMorph2-Core.package/M2Backend.class/instance/isInTextMode.st
Outdated
Show resolved
Hide resolved
packages/SketchMorph2-Core.package/M2Backend.class/instance/commitText.st
Outdated
Show resolved
Hide resolved
This temporary placement at |
When clicking the Choose Font - button while having the text tool activated it is possible to draw on the canvas even though only writing text should be allowed. |
Should be fixed. |
interaction | ||
dismissCurrent | ||
self canvas ifNotNil: [self canvas removeMorph: self]. | ||
ActiveHand newKeyboardFocus: nil. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one is being set twice. Once in the sender of dismissCurrent
and once here. I suggest removing this line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd suggest removing it in the sender since we are also setting the focus in M2TemporaryTextMorph>>getAt:
, so I think the same class should be responsible for releasing the focus.
packages/SketchMorph2-Core.package/M2Backend.class/instance/userActionMoveDrawing..st
Outdated
Show resolved
Hide resolved
packages/SketchMorph2-Core.package/MorphicMonetIcons.class/class/editIconContents.st
Outdated
Show resolved
Hide resolved
packages/SketchMorph2-Core.package/MorphicMonetIcons.class/class/uiTextFieldIconContents.st
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't quite get the need for M2TemporaryTextMorph
, what is the benefit of having such a temporary text morph, moving it to the target position and eventually creating a new Textmorph
to print the text over simply creating a TextMorph
at the target position and printing its contents?
packages/SketchMorph2-Core.package/M2Backend.class/instance/commitText.st
Outdated
Show resolved
Hide resolved
packages/SketchMorph2-Core.package/M2Backend.class/instance/commitText.st
Outdated
Show resolved
Hide resolved
packages/SketchMorph2-Core.package/M2Backend.class/instance/switchMode.st
Show resolved
Hide resolved
@@ -0,0 +1,6 @@ | |||
interaction | |||
getAt: aPoint |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
getAt:
sounds weird to me since the morph already exists. Maybe use moveTo:
instead?
getAt: aPoint | ||
self position: aPoint. | ||
self canvas ifNotNil: [self canvas addMorph: self]. | ||
ActiveHand newKeyboardFocus: self. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ActiveHand newKeyboardFocus: self. | |
self activeHand newKeyboardFocus: self. |
b7fad04
to
cbf1da9
Compare
Closes #35