Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split up environment #154

Merged
merged 17 commits into from
Jun 9, 2023
Merged

Split up environment #154

merged 17 commits into from
Jun 9, 2023

Conversation

LinqLover
Copy link
Collaborator

@LinqLover LinqLover commented Nov 9, 2022

Closes #69.

Next steps before merging:

  • Reread entire affected chapters to catch more interdependencies.
  • Fix CI for new script.

Without, there was an awful overfull hbox in SourceControl.
Move sections on Monticello, change sets, recover changes, and git to the new chapter. Add short overview of tools in chapter SourceControl. Minor revisions on SourceControl:

- Monticello: add IPA spelling on the tool's name
- mention drop to install into new changeset and add a figure for it
- cantLoseCode: update malicious crash example (sorry we don't have an assertion for this 🤡)
- very minor rephrasing/spelling corrections on change sorters, file list browser, and cantLoseCode

Swap method finder and message names in Environment overview.
@LinqLover LinqLover added the enhancement New feature or request label Nov 9, 2022
@LinqLover LinqLover self-assigned this Nov 9, 2022
@LinqLover LinqLover assigned codeZeilen and unassigned LinqLover Jun 8, 2023
@LinqLover LinqLover assigned LinqLover and unassigned codeZeilen Jun 8, 2023
@LinqLover LinqLover marked this pull request as ready for review June 8, 2023 17:05
@LinqLover LinqLover requested a review from codeZeilen June 8, 2023 17:05
- remove unnecessary indexing of yellow button menu
- add interlude sentence before extension methods
- some formatting and stale comments improved
@codeZeilen codeZeilen merged commit a6c8627 into master Jun 9, 2023
@codeZeilen codeZeilen deleted the split-up-environment branch June 9, 2023 09:35
@LinqLover LinqLover mentioned this pull request Jun 27, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rework structuring of Chapter 6: The Environment
2 participants