Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HPCC-27051 create a sasha service to clean up post mortem files #19588

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

HPCC-27051 create a sasha service to clean up post mortem files #19588

wants to merge 1 commit into from

Conversation

streeterd
Copy link
Contributor

@streeterd streeterd commented Mar 5, 2025 •
edited
Loading

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change improves the code (refactor or other change that does not change the functionality)
  • This change fixes warnings (the fix does not alter the functionality or the generated code)
  • This change is a breaking change (fix or feature that will cause existing behavior to change).
  • This change alters the query API (existing queries will have to be recompiled)

Checklist:

  • My code follows the code style of this project.
    • My code does not create any new warnings from compiler, build system, or lint.
  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit is signed.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the CONTRIBUTORS document.
  • The change has been fully tested:
    • I have added tests to cover my changes.
    • All new and existing tests passed.
    • I have checked that this change does not introduce memory leaks.
    • I have used Valgrind or similar tools to check for potential issues.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Cloud-compatibility
    • Premature optimization
    • Existing deployed queries will not be broken
    • This change fixes the problem, not just the symptom
    • The target branch of this pull request is appropriate for such a change.
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised JIRA issues to address them separately
  • This is a user interface / front-end modification
    • I have tested my changes in multiple modern browsers
    • The component(s) render as expected

Smoketest:

  • Send notifications about my Pull Request position in Smoketest queue.
  • Test my draft Pull Request.

Testing:

@streeterd streeterd requested a review from Copilot March 5, 2025 16:19
@streeterd streeterd self-assigned this Mar 5, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 5, 2025

Jira Issue: https://hpccsystems.atlassian.net//browse/HPCC-27051

Jirabot Action Result:
Workflow Transition To: Merge Pending
Additional PR: #19588

Copilot
Copilot AI reviewed Mar 5, 2025
View reviewed changes

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Overview

This PR creates a new "debug-housekeeping" configuration for the sasha service, intended to support cleanup of post mortem files by providing an optional debug mode for housekeeping tasks.

  • Introduces a "debug-housekeeping" block in the primary values file with default (empty object) settings.
  • Adds corresponding "debug-housekeeping" configurations in multiple test YAML files, enabling or disabling the debug housekeeping feature.
  • Augments resourced test files with a "resources" block under "debug-housekeeping" for additional resource allocation.

Reviewed Changes

File Description
helm/hpcc/values.yaml Added "debug-housekeeping" with default settings
testing/helm/tests/multicertdomains.yaml Added "debug-housekeeping" with disabled flag
testing/helm/tests/values-hpcc2.yaml Added "debug-housekeeping" with disabled flag
testing/helm/tests/values-hpcc1.yaml Added "debug-housekeeping" with disabled flag
testing/helm/tests/resourced.yaml Added "debug-housekeeping" with commented config and resource sub-block
testing/helm/tests/resourced2.yaml Added "debug-housekeeping" with commented config and resource sub-block

Copilot reviewed 21 out of 21 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

helm/hpcc/values.yaml:516

  • [nitpick] Consider removing or clarifying the commented configuration options below 'debug-housekeeping'. Either define a full default structure or remove the commented lines to provide clearer guidance to users.
debug-housekeeping: {} # NB: no properties defined, use defaults
@streeterd streeterd requested review from Copilot and jakesmith March 7, 2025 11:50
Copilot
Copilot AI reviewed Mar 7, 2025
View reviewed changes

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Overview

This pull request creates a new Sasha service to clean up post mortem files by adding a new debugging configuration for housekeeping tasks. The changes introduce a "debug-housekeeping" block in multiple Helm values files to control the behavior of the service, with variations between production and test configurations.

  • Added a debug-housekeeping block with an empty/default configuration in helm/hpcc/values.yaml.
  • Enabled/disabled debug-housekeeping in various test files (multicertdomains.yaml, values-hpcc1.yaml, values-hpcc2.yaml, resourced.yaml, resourced2.yaml).

Reviewed Changes

File Description
helm/hpcc/values.yaml Added a debug-housekeeping block with default (empty) values.
testing/helm/tests/multicertdomains.yaml Added debug-housekeeping block; set to disabled for testing.
testing/helm/tests/values-hpcc2.yaml Added debug-housekeeping block; set to disabled for testing.
testing/helm/tests/values-hpcc1.yaml Added debug-housekeeping block; set to disabled for testing.
testing/helm/tests/resourced.yaml Added debug-housekeeping block with additional resource limits.
testing/helm/tests/resourced2.yaml Added debug-housekeeping block with additional resource limits.

Copilot reviewed 20 out of 20 changed files in this pull request and generated no comments.
@streeterd streeterd marked this pull request as ready for review March 10, 2025 10:34
streeterd
streeterd commented Mar 10, 2025
View reviewed changes
dali/sasha/sadbghk.cpp
}
else
{
PROGLOG(LOGDBGHK "Non post-mortem dir: %s", dirName.str());
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jakesmith do we need this log?
I added it in case there were folders that we not expected.

streeterd
streeterd commented Mar 10, 2025
View reviewed changes
dali/sasha/sadbghk.cpp
RegExpr postMortemDirRegEx("^W[0-9][0-9][0-9][0-9][0-9][0-9][0-9][0-9]-[0-9][0-9][0-9][0-9][0-9][0-9]$");
if (postMortemDirRegEx.find(dirName.str()))
{
PROGLOG(LOGDBGHK "Post-mortem dir: %s", dirName.str());
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jakesmith do we need this log?
Could it be useful as a DBGLOG ?

streeterd
streeterd commented Mar 10, 2025
View reviewed changes
dali/sasha/sadbghk.cpp

if (now.compare(expires, false) > 0)
{
PROGLOG(LOGDBGHK "Post-mortem dir: %s has expired", dirName.str());
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jakesmith is this log needed?
The dir will be deleted and logged anyway.

@streeterd
HPCC-27051 Create a Sasha service to clean up post-mortem files
a9d6361 
Create new Sasha Debug Housekeeping service to delete post-mortem directories on the debug plane.

Signed-off-by: Dave Streeter <dave.streeter@lexisnexisrisk.com>
@streeterd streeterd force-pushed the HPCC-27051_Create_a_Sasha_service_to_clean_up_post-mortem_files branch from 20c2064 to a9d6361 Compare March 11, 2025 09:56
@streeterd streeterd requested a review from Copilot March 11, 2025 09:56
Copilot
Copilot AI reviewed Mar 11, 2025
View reviewed changes
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Overview

This PR introduces a new sasha service for cleaning up post mortem files by adding a debug-housekeeping configuration option. The key changes include:

  • Adding a debug-housekeeping section with default and commented optional properties in helm/hpcc/values.yaml.
  • Updating multiple test configuration files to include a debug-housekeeping configuration with the "disabled" flag.
  • Adding resource configuration for debug-housekeeping in resourced test files.

Reviewed Changes

File Description
helm/hpcc/values.yaml Adds a debug-housekeeping configuration with default values.
testing/helm/tests/values-hpcc1.yaml Introduces debug-housekeeping with "disabled: true".
testing/helm/tests/values-hpcc2.yaml Introduces debug-housekeeping with "disabled: true".
testing/helm/tests/multicertdomains.yaml Introduces debug-housekeeping with "disabled: true".
testing/helm/tests/resourced2.yaml Adds debug-housekeeping with resource limits.
testing/helm/tests/resourced.yaml Adds debug-housekeeping with resource limits.

Copilot reviewed 17 out of 17 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

testing/helm/tests/resourced.yaml:514

  • The debug-housekeeping block contains several commented out properties alongside an active resources block, which may cause confusion; consider cleaning up the commented properties or providing clear documentation to standardize its use.
debug-housekeeping:

helm/hpcc/values.yaml
@@ -513,6 +513,13 @@ sasha:
#switchMinTime: 1
#queues: "*"

debug-housekeeping: {} # NB: no properties defined, use defaults
Copy link
Preview

Copilot AI Mar 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The inline declaration using '{}' differs in structure from the block style used in test files; consider aligning the structure (e.g. using a block style with a 'disabled' property) to ensure consistent configuration behavior.

Copilot is powered by AI, so mistakes are possible. Review output carefully before use.

Positive Feedback
Negative Feedback

Provide additional feedback

Please help us improve GitHub Copilot by sharing more details about this comment.

Please select one or more of the options
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new code matches the existing code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@jakesmith jakesmith Awaiting requested review from jakesmith

At least 1 approving review is required to merge this pull request.

Assignees

@streeterd streeterd

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@streeterd