Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HPCC-33057 Allow attributes for implicit storage planes to be merged #19364

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

HPCC-33057 Allow attributes for implicit storage planes to be merged #19364

wants to merge 3 commits into from

Conversation

jackdelv
Copy link
Contributor

@jackdelv jackdelv commented Dec 16, 2024 •
edited
Loading

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change improves the code (refactor or other change that does not change the functionality)
  • This change fixes warnings (the fix does not alter the functionality or the generated code)
  • This change is a breaking change (fix or feature that will cause existing behavior to change).
  • This change alters the query API (existing queries will have to be recompiled)

Checklist:

  • My code follows the code style of this project.
    • My code does not create any new warnings from compiler, build system, or lint.
  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit is signed.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the CONTRIBUTORS document.
  • The change has been fully tested:
    • I have added tests to cover my changes.
    • All new and existing tests passed.
    • I have checked that this change does not introduce memory leaks.
    • I have used Valgrind or similar tools to check for potential issues.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Cloud-compatibility
    • Premature optimization
    • Existing deployed queries will not be broken
    • This change fixes the problem, not just the symptom
    • The target branch of this pull request is appropriate for such a change.
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised JIRA issues to address them separately
  • This is a user interface / front-end modification
    • I have tested my changes in multiple modern browsers
    • The component(s) render as expected

Smoketest:

  • Send notifications about my Pull Request position in Smoketest queue.
  • Test my draft Pull Request.

Testing:

@github-actions GitHub Actions
Copy link

Jira Issue: https://hpccsystems.atlassian.net//browse/HPCC-33057

Jirabot Action Result:
Workflow Transition To: Merge Pending
Updated PR

@jackdelv jackdelv requested a review from ghalliday December 16, 2024 16:19
@ghalliday
Copy link
Member

This will need rebasing/reviewing after #19362 is reviewed/merged.

@ghalliday
Copy link
Member

@jackdelv please can you convert this to a normal PR and retest it with the most recent version of the platform.

ghalliday
ghalliday reviewed Jan 16, 2025
View reviewed changes
Copy link
Member

@ghalliday ghalliday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please can you convert this to a normal PR and retest it with the most recent version of the platform. Then re-tag me for review.

jackdelv added 2 commits March 6, 2025 09:43
@jackdelv
HPCC-33057 Allow attributes for implicit storage planes to be merged
8d4b2b4 
Signed-off-by: Jack Del Vecchio <jack.delvecchio@lexisnexisrisk.com>
@jackdelv
Check for mirror name first
24fb144
@jackdelv jackdelv marked this pull request as ready for review March 6, 2025 15:46
@jackdelv jackdelv requested a review from ghalliday March 6, 2025 15:46
ghalliday
ghalliday requested changes Mar 11, 2025
View reviewed changes
Copy link
Member

@ghalliday ghalliday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most changes look reasonable.

system/jlib/jfile.cpp Outdated
@@ -8045,7 +8046,7 @@ static PlaneAttributesMapElement *findPlaneElementFromPath(const char *filePath)
for (auto &e: planeAttributesMap)
{
const char *prefix = e.second.first.c_str();
if (prefix) // sanity check, but should never be null
if (isEmptyString(prefix)) // sanity check, std::string cannot be null, so check if empty
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test has been inverted. Should be !isEmptyString()

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jakesmith we should have some unit tests to catch problems like this. Not quite sure how to code them easily though.

@jackdelv jackdelv requested a review from ghalliday March 11, 2025 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghalliday ghalliday Awaiting requested review from ghalliday

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jackdelv @ghalliday