-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
185 support for new portal myuplinkcom #197
Conversation
tests/MockPlatform.ts
Outdated
@@ -1,7 +1,7 @@ | |||
import {PlatformAdapter} from '../src/nibe/PlatformAdapter'; | |||
import {Accessory, Characteristic, Service} from '../src/nibe/DataModel'; | |||
import {Fetcher} from '../src/nibe/Fetcher'; | |||
import {Data} from '../src/nibe/uplink/nibe-dto'; | |||
import {Data} from '../src/nibe/myuplink/nibe-dto'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [tsc] <2307> reported by reviewdog 🐶
Cannot find module '../src/nibe/myuplink/nibe-dto' or its corresponding type declarations.
@@ -0,0 +1,6 @@ | |||
export interface Logger { | |||
info(message: string, ...parameters: any[]): void; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unexpected any. Specify a different type.
@@ -0,0 +1,6 @@ | |||
export interface Logger { | |||
info(message: string, ...parameters: any[]): void; | |||
warn(message: string, ...parameters: any[]): void; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unexpected any. Specify a different type.
export interface Logger { | ||
info(message: string, ...parameters: any[]): void; | ||
warn(message: string, ...parameters: any[]): void; | ||
error(message: string, ...parameters: any[]): void; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unexpected any. Specify a different type.
info(message: string, ...parameters: any[]): void; | ||
warn(message: string, ...parameters: any[]): void; | ||
error(message: string, ...parameters: any[]): void; | ||
debug(message: string, ...parameters: any[]): void; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unexpected any. Specify a different type.
|
||
export interface AccessoryInstance { | ||
context: AccessoryContext | ||
getService(type: any): ServiceInstance; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unexpected any. Specify a different type.
export interface AccessoryInstance { | ||
context: AccessoryContext | ||
getService(type: any): ServiceInstance; | ||
addService(type: any): ServiceInstance; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unexpected any. Specify a different type.
} | ||
|
||
export interface ServiceInstance { | ||
updateCharacteristic(type: any, value: any): void; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unexpected any. Specify a different type.
} | ||
|
||
export interface ServiceInstance { | ||
updateCharacteristic(type: any, value: any): void; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unexpected any. Specify a different type.
return `${data?.device?.id || 'undefined'}::${this.name}`; | ||
} | ||
|
||
public buildName(data: Data) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'data' is defined but never used.
return platformAccessory.context.version >= this.version; | ||
} | ||
|
||
public update(platformAccessory: AccessoryInstance, data: Data): void { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'data' is defined but never used.
this.locale = new Locale(config.language, log); | ||
|
||
this.serviceResolver = { | ||
resolveCharacteristic(type: any) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unexpected any. Specify a different type.
No description provided.