Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

185 support for new portal myuplinkcom #197

Merged
merged 27 commits into from
Sep 24, 2024

Conversation

hpruszyn
Copy link
Contributor

No description provided.

@hpruszyn hpruszyn linked an issue Jun 26, 2024 that may be closed by this pull request
@@ -1,7 +1,7 @@
import {PlatformAdapter} from '../src/nibe/PlatformAdapter';
import {Accessory, Characteristic, Service} from '../src/nibe/DataModel';
import {Fetcher} from '../src/nibe/Fetcher';
import {Data} from '../src/nibe/uplink/nibe-dto';
import {Data} from '../src/nibe/myuplink/nibe-dto';

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [tsc] <2307> reported by reviewdog 🐶
Cannot find module '../src/nibe/myuplink/nibe-dto' or its corresponding type declarations.

@@ -0,0 +1,6 @@
export interface Logger {
info(message: string, ...parameters: any[]): void;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <@typescript-eslint/no-explicit-any> reported by reviewdog 🐶
Unexpected any. Specify a different type.

@@ -0,0 +1,6 @@
export interface Logger {
info(message: string, ...parameters: any[]): void;
warn(message: string, ...parameters: any[]): void;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <@typescript-eslint/no-explicit-any> reported by reviewdog 🐶
Unexpected any. Specify a different type.

export interface Logger {
info(message: string, ...parameters: any[]): void;
warn(message: string, ...parameters: any[]): void;
error(message: string, ...parameters: any[]): void;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <@typescript-eslint/no-explicit-any> reported by reviewdog 🐶
Unexpected any. Specify a different type.

info(message: string, ...parameters: any[]): void;
warn(message: string, ...parameters: any[]): void;
error(message: string, ...parameters: any[]): void;
debug(message: string, ...parameters: any[]): void;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <@typescript-eslint/no-explicit-any> reported by reviewdog 🐶
Unexpected any. Specify a different type.


export interface AccessoryInstance {
context: AccessoryContext
getService(type: any): ServiceInstance;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <@typescript-eslint/no-explicit-any> reported by reviewdog 🐶
Unexpected any. Specify a different type.

export interface AccessoryInstance {
context: AccessoryContext
getService(type: any): ServiceInstance;
addService(type: any): ServiceInstance;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <@typescript-eslint/no-explicit-any> reported by reviewdog 🐶
Unexpected any. Specify a different type.

}

export interface ServiceInstance {
updateCharacteristic(type: any, value: any): void;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <@typescript-eslint/no-explicit-any> reported by reviewdog 🐶
Unexpected any. Specify a different type.

}

export interface ServiceInstance {
updateCharacteristic(type: any, value: any): void;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <@typescript-eslint/no-explicit-any> reported by reviewdog 🐶
Unexpected any. Specify a different type.

return `${data?.device?.id || 'undefined'}::${this.name}`;
}

public buildName(data: Data) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <@typescript-eslint/no-unused-vars> reported by reviewdog 🐶
'data' is defined but never used.

return platformAccessory.context.version >= this.version;
}

public update(platformAccessory: AccessoryInstance, data: Data): void {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <@typescript-eslint/no-unused-vars> reported by reviewdog 🐶
'data' is defined but never used.

this.locale = new Locale(config.language, log);

this.serviceResolver = {
resolveCharacteristic(type: any) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <@typescript-eslint/no-explicit-any> reported by reviewdog 🐶
Unexpected any. Specify a different type.

@hpruszyn hpruszyn merged commit ff5b1dd into main Sep 24, 2024
4 checks passed
@hpruszyn hpruszyn deleted the 185-support-for-new-portal-myuplinkcom branch September 24, 2024 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for new portal myuplink.com
1 participant