Contribute Cisco Jabber XMPP connector to botkit #1169
Conversation
docs/readme-ciscojabber.md
Outdated
| }); | ||
| var bot = controller.spawn({ | ||
| client: { | ||
| jid: ‘xx@domain.com', |
There was a problem hiding this comment.
Wrong opening quote here.
docs/readme-ciscojabber.md
Outdated
| |--- |--- | ||
| | jid | Jid of the jabber bot | ||
| | password | Password of the jabber bot | ||
| | host | host of the Cisco Unified IM & Presence server, no need for bot of Cisco WebEx Messenger |
There was a problem hiding this comment.
If all descriptions start with capital letter, this one should start with H.
not necessary would look better than no need.
docs/readme-ciscojabber.md
Outdated
| let mention_jids = []; | ||
| if (match) { | ||
| for (let i = 0; i < match.length; i++) { | ||
| let jid_match = match[i].match(email_reg); |
There was a problem hiding this comment.
Please indent all statements in function body properly.
lib/JabberBot.js
Outdated
|
|
||
| xmpp.on('subscribe', function (from) { | ||
| xmpp.acceptSubscription(from); | ||
| console.log('accept subscribe from' + from); |
There was a problem hiding this comment.
Please add a space between from and closing quote '.
lib/JabberBot.js
Outdated
| return false; | ||
| } | ||
|
|
||
| function ExtractMentionJids(message) { |
There was a problem hiding this comment.
ExtractMentionJids function is not a constructor so it should start with lowercase e.
package.json
Outdated
| "ws": "^2.2.2", | ||
| "node-ews": "^3.2.2", | ||
| "node-xmpp-caps": "0.0.2", | ||
| "simple-xmpp": "^1.3.0" |
There was a problem hiding this comment.
Please put new dependencies to alphabetically correct positions.
Putting then at the bottom also creates an unnecessary conflict with #1154.
|
This will be included in the next update of Botkit. |
|
Great to know, thanks Peter for the help on it.
Thanks,
Qiongfang
在 2018年2月10日，上午4:33，Peter Swimm <notifications@github.com<mailto:notifications@github.com>> 写道：
This will be included in the next updated of Botkit
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#1169 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AHoYLCrkrjmnPSGOe6LhpNCrhW2OEfv_ks5tTKu1gaJpZM4Q6nc->.
|
We open this pull request to contribute Cisco Jabber XMPP connector into botkit framework. People can create Cisco Jabber Bot based on botkit framework, connect to Cisco Webex messenger servers and Cisco IM&Presence servers. More details for the Jabber Bot can be found in the readme-jabberbot.md and in the attached documents.
ChatBot-CallFlow-Example.docx