feat: remove 'mutable-model' feature #883
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature, that was introduced for an experimentation, didn't prove itself safe and constrained enough. Let's remove it.
Original PR was #761.
For details, opening this door of mutability was opening an opportunity to make the
Model
inconsistent. The consequence of that would be disastrous, since relations in the graph might become incorrect, the information incoherent and raise subtle bugs that might be hard to debug and fix.Another problem with this modification, we modify the
Model
after it has been sanitized. But creating newCalendar
was added, possibly connected, but possibly not (because other API for connecting), which means theModel
probably ends up with orphanCalendar
that should be sanitized (even if connected, the one that has been replaced might have become an orphan).