[feature] upgrade to ntfs 0.12 #809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woshilapin
reviewed
Aug 26, 2021
| @@ -115,6 +115,7 @@ pub struct Collections { | |||
| pub grid_exception_dates: Collection<GridExceptionDate>, | |||
| pub grid_periods: Collection<GridPeriod>, | |||
| pub grid_rel_calendar_line: Collection<GridRelCalendarLine>, | |||
| pub addresses: CollectionWithId<Address>, | |||
There was a problem hiding this comment.
Should we also add a new entry in Model, something like
adresses_to_stop_points: OneToMany<Address, StopPoint>,
It might be too early to think about adding this. If we don't have a use for it right now, we might just delay the creation of such relation for later.
woshilapin
previously approved these changes
Aug 27, 2021
|
@patochectp |
57663fd to
e494476
Compare
ArnaudOggy
approved these changes
Aug 30, 2021
woshilapin
approved these changes
Aug 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: ND-1498