Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] use the new Iterator::skip_error #781

Merged
merged 1 commit into from
May 24, 2021
Merged

Conversation

woshilapin
Copy link
Contributor

Some possible use of skip_error_and_log() on Iterator. Depends on hove-io/skip_error#9.

antoine-de
antoine-de previously approved these changes May 11, 2021
@woshilapin
Copy link
Contributor Author

hove-io/skip_error#9 has been merged and skip_error:1.1.0 released. I updated the Cargo.toml and removed the do_not_merge label.

datanel
datanel previously approved these changes May 12, 2021
Copy link
Contributor

@pbougue pbougue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should probably update the cargo.toml to skip_error = "1.1".

@ArnaudOggy
Copy link
Contributor

ArnaudOggy commented May 24, 2021

@woshilapin

  • a little bump to 0.36.1 in Cargo for next release 😉

@woshilapin
Copy link
Contributor Author

@woshilapin

* a little bump to `0.36.1` in Cargo for next release wink

Indeed. Done in 68e241d.

@woshilapin
Copy link
Contributor Author

You should probably update the cargo.toml to skip_error = "1.1".

Good point, done in ec59328.

@woshilapin woshilapin merged commit 94d67e6 into master May 24, 2021
@woshilapin woshilapin deleted the skip_error_iter branch May 24, 2021 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants