[tech] add notification to slack #775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 3, 2021 20:02
- add notification for all jobs to slack in case `failure` and master `branch` - add a Webhook secret in GitHub - add a `global variable` formated message text in workflow
pbougue
reviewed
May 4, 2021
pbougue
reviewed
May 4, 2021
.github/workflows/publish.yml
Outdated
| SLACK_TEXT: '{"attachments":[{ | ||
| "pretext": "`transit_model Publish` requires your attention!", | ||
| "text":" :warning: Publish failed!","color":"#D00000", | ||
| "fields":[{"title":"Action URL","value": "https://github.com:/${{ github.action_path }}/${{ github.repository }}/actions/runs/${{ github.run_id }}"}]} |
There was a problem hiding this comment.
(If you want to test it, maybe just use echo instead of curl to avoid spamming slack 🥫)
It does work, but it doesn't look like a legit url 🤔
Maybe more:
Suggested change
| "fields":[{"title":"Action URL","value": "https://github.com:/${{ github.action_path }}/${{ github.repository }}/actions/runs/${{ github.run_id }}"}]} | |
| "fields":[{"title":"Action URL","value": "https://github.com${{ github.action_path }}/${{ github.repository }}/actions/runs/${{ github.run_id }}"}]} |
Also, I don't know if what's suggested here would work (probably better if possible, as it's straight from official doc): $GITHUB_SERVER_URL/$GITHUB_REPOSITORY/actions/runs/$GITHUB_RUN_ID
There was a problem hiding this comment.
i change url and test it. Done
pbougue
approved these changes
May 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
failureandmasterbranchSLACK_CORE_TOOLS_TEAM_URL: hereglobal variablein workflow