[feature] Add the ability to read ziped ntfs #773
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
change the
transit_model::ntfs::read
method to be able to read a zip archivelike the
gtfs
module, the ntfs module now have:It also brings a lower level
from_read
method if one day we want more flexible reading options like:The global behavior can be check in the test file
tests/read_ntfs.rs
.Note: from method visibility have been changed from
pub
topub(crate)
to not expose theFileHandler
, so this is a breaking change. However I don't think those methods were used in practice. At least not internally by Kisio.