We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
@TeXitoi To be discussed, as there's no PR to discuss on.
https://github.com/CanalTP/navitia_model/blob/9327364e29645194cb79866609131e657dff2be8/src/lib.rs#L79 I'd name it Context more than PtObjects
Context
https://github.com/CanalTP/navitia_model/blob/9327364e29645194cb79866609131e657dff2be8/src/lib.rs#L10 :) not able to read or maintain that... We have to take a course on that! Maybe clearer (longer) macro param names (what is ty for?)?
ty
https://github.com/CanalTP/navitia_model/blob/09d7b0d4913b8df7469977c7fa0d4e8baf5b60e5/get-corresponding-derive/src/lib.rs#L12 Again the naming is not super helping, or missing comments (also the case for get-corresponding-derive/src/lib.rs in general)?
The text was updated successfully, but these errors were encountered:
pt_objects
Sorry, something went wrong.
Merge pull request #1 from woshilapin/update_gtfs_parser-from
83c445d
Transform Into implementation into From
fix: update docker images for proj:8.1.0 (#1)
5ce5654
No branches or pull requests
@TeXitoi To be discussed, as there's no PR to discuss on.
https://github.com/CanalTP/navitia_model/blob/9327364e29645194cb79866609131e657dff2be8/src/lib.rs#L79
I'd name it
Context
more than PtObjectshttps://github.com/CanalTP/navitia_model/blob/9327364e29645194cb79866609131e657dff2be8/src/lib.rs#L10
:) not able to read or maintain that... We have to take a course on that! Maybe clearer (longer) macro param names (what is
ty
for?)?https://github.com/CanalTP/navitia_model/blob/09d7b0d4913b8df7469977c7fa0d4e8baf5b60e5/get-corresponding-derive/src/lib.rs#L12
Again the naming is not super helping, or missing comments (also the case for get-corresponding-derive/src/lib.rs in general)?
The text was updated successfully, but these errors were encountered: