Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge from main #2

Merged
merged 27 commits into from
Nov 12, 2023
Merged
Changes from 1 commit
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
ad6fa27
[chore] move collectdreceiver shared code to an internal package (#28…
atoulme Nov 6, 2023
6696f7e
[chore] Increase Cache Go step timeout to 25min on Windows (#28859)
pjanotti Nov 6, 2023
1955509
[exporter/datadog] fix(docs): typo with especially (#28996)
karmingc Nov 6, 2023
c53db30
Bump github.com/google/cadvisor from 0.47.3 to 0.48.1 in /receiver/aw…
crobert-1 Nov 7, 2023
dbfa694
[receiver/kafkametrics] Using unique container networks and container…
sakulali Nov 7, 2023
902b1a9
[chore][processort/tailsamplingprocessor] Limit concurrency for certa…
pjanotti Nov 8, 2023
c26444b
Codesmon/exporter/azuremonitor/persistent queue (#26258)
codesmon Nov 8, 2023
cec3e59
[chore] update affiliation (#29019)
Nov 8, 2023
a80edda
[receiver/collectd] move collectdreceiver to beta (#28997)
atoulme Nov 8, 2023
22d86de
[chore] dependabot updates Wed Nov 8 16:58:54 UTC 2023 (#29028)
opentelemetrybot Nov 8, 2023
eb320a1
[chore] dependabot updates Wed Nov 8 18:29:02 UTC 2023 (#29052)
opentelemetrybot Nov 8, 2023
c95d613
[chore] dependabot updates Wed Nov 8 21:01:03 UTC 2023 (#29071)
opentelemetrybot Nov 8, 2023
b595986
[exporter/influxdb] Remove //nolint indent-error-flow (#29073)
yukinakanaka Nov 8, 2023
65b745f
hostmetricsreceiver: remove unused function (#29075)
braydonk Nov 8, 2023
330ff0a
[chore] bump go versions in workflows to 1.20.11 and 1.21.4 (#29080)
adrielp Nov 9, 2023
f4c4485
[all][chore] Moved from interface{} to any for all go code (#29072)
lucasoskorep Nov 9, 2023
57b5dcc
[receiver/dockerstats] rename struct and function to keep expected re…
sakulali Nov 9, 2023
320eff4
[receiver/mongodbatlasreceiver] add provider resource attributes (#28…
JonathanWamsley Nov 9, 2023
b716a4d
[exporter/syslog] Enable component (#28902)
kasia-kujawa Nov 9, 2023
e8116e6
[chore][pkg/stanza]: when found duplicate, continue from outer loop (…
VihasMakwana Nov 10, 2023
bf5a3f8
udp-receiver async - fix data corruption (with buffer pools) (#28898)
hovavza Nov 10, 2023
55a7d9d
[chore][receiver/windowseventlog] remove duplicate function NewFactor…
sakulali Nov 10, 2023
21469b1
[chore][pkg/stanza][exporter/signalfx] One more interface{} -> any an…
songy23 Nov 10, 2023
361b070
[chore][CONTRIBUTING.md] Add triage process link (#29092)
crobert-1 Nov 10, 2023
cd0ffe1
fix(processor/k8sattributes): README was misleading/had typoes (#29108)
lizthegrey Nov 11, 2023
61ba7fd
[processor/k8sattributes] fix(docs): typo for kubernetes label (#29110)
karmingc Nov 11, 2023
1d4cf91
Update doc.go of filelogreceiver (#29100)
Nov 12, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix(processor/k8sattributes): README was misleading/had typoes (open-…
…telemetry#29108)

**Description:**
Fixes misleading documentation about which RBAC role is required and
other invalid YAML I found along the way
  • Loading branch information
lizthegrey authored Nov 11, 2023
commit cd0ffe15009aa28ef3d116b272df80b6386d7709
8 changes: 4 additions & 4 deletions processor/k8sattributesprocessor/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -158,9 +158,9 @@ k8sattributes/2:

## Role-based access control

The k8sattributesprocessor needs `get`, `watch` and `list` permissions on both `pods` and `namespaces` resources, for all namespaces and pods included in the configured filters. Additionally, when using `k8s.deployment.uid` or `k8s.deployment.name` the processor also needs `get`, `watch` and `list` permissions for `replicaset` resources. When extracting metadatas from `node`, the processor needs `get`, `watch` and `list` permissions for `node` resources.
The k8sattributesprocessor needs `get`, `watch` and `list` permissions on both `pods` and `namespaces` resources, for all namespaces and pods included in the configured filters. Additionally, when using `k8s.deployment.uid` or `k8s.deployment.name` the processor also needs `get`, `watch` and `list` permissions for `replicasets` resources. When extracting metadatas from `node`, the processor needs `get`, `watch` and `list` permissions for `nodes` resources.

Here is an example of a `ClusterRole` to give a `ServiceAccount` the necessary permissions for all pods and namespaces in the cluster (replace `<OTEL_COL_NAMESPACE>` with a namespace where collector is deployed):
Here is an example of a `ClusterRole` to give a `ServiceAccount` the necessary permissions for all pods, nodes, and namespaces in the cluster (replace `<OTEL_COL_NAMESPACE>` with a namespace where collector is deployed):

```yaml
apiVersion: v1
Expand All @@ -175,7 +175,7 @@ metadata:
name: otel-collector
rules:
- apiGroups: [""]
resources: ["pods", "namespaces"]
resources: ["pods", "namespaces", "nodes"]
verbs: ["get", "watch", "list"]
- apiGroups: ["apps"]
resources: ["replicasets"]
Expand Down Expand Up @@ -220,7 +220,7 @@ to complete the following steps:
Add the following snippet under the pod env section of the OpenTelemetry container.

```yaml
2. spec:
spec:
containers:
- env:
- name: KUBE_NODE_NAME
Expand Down