Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump actions/upload-artifact to v4 to get CI green again #1368

Merged
merged 1 commit into from
Feb 14, 2025

Conversation

botandrose
Copy link
Contributor

All PRs are currently red because GitHub has intentionally broken actions/upload-artifact@v3 to force an upgrade to v4.

From any recent CI run:

Error: This request has been automatically failed because it uses a deprecated version of actions/upload-artifact: v3. Learn more: https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/

Below are the breaking changes for v4, none of which seem to apply to Turbo, so a simple bump should do.
https://github.com/actions/upload-artifact?tab=readme-ov-file#breaking-changes

Copy link
Collaborator

@brunoprietog brunoprietog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @botandrose!

@brunoprietog brunoprietog merged commit 5a34d90 into hotwired:main Feb 14, 2025
1 check passed
@botandrose botandrose deleted the patch-1 branch February 14, 2025 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants