Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test coverage for submitting form[data-turbo-frame="_top"] #1038

Merged
merged 1 commit into from
Oct 23, 2023

Conversation

seanpdoyle
Copy link
Contributor

Closes #901

Add test coverage for submitting <form> elements with [data-turbo-frame="_top"]. Coverage includes both <form> elements outside of <turbo-frame> and <form> elements that are descendants of <turbo-frame> elements.

Closes [hotwired#901][]

Add test coverage for submitting `<form>` elements with
`[data-turbo-frame="_top"]`. Coverage includes both `<form>` elements
outside of `<turbo-frame>` *and* `<form>` elements that are descendants
of `<turbo-frame>` elements.

[hotwired#901]: hotwired#901
@afcapel afcapel merged commit 0b5f53b into hotwired:main Oct 23, 2023
@afcapel
Copy link
Collaborator

afcapel commented Oct 23, 2023

Thanks again, @seanpdoyle

@seanpdoyle seanpdoyle deleted the issue-901 branch October 23, 2023 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Turbo Frame on post submit not updating with _top
2 participants