Add test coverage for StreamActions export
#1023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanpdoyle
added a commit
to seanpdoyle/turbo
that referenced
this pull request
Oct 8, 2023
afcapel
reviewed
Oct 23, 2023
138b9c4 to
d88e99c
Compare
afcapel
reviewed
Oct 23, 2023
src/index.js
Outdated
| @@ -10,3 +10,4 @@ Turbo.start() | |||
| export * from "./core" | |||
There was a problem hiding this comment.
After the last push, isn't this export already exporting StreamActions?
There was a problem hiding this comment.
You're right, I've reduced this diff to test coverage only.
According to the [official documentation][], applications that need to extend `StreamActions` should be importing it directly from the module instead of accessing it through `window.Turbo.StreamActions`. This commit adds test coverage to exercise the corresponding `import`. It also re-arranges the `export` to explicitly occur in the `@hotwired/turbo` module itself, instead of being transitively exported as part of the `@hotwired/turbo/core` module. [official documentation]: https://turbo.hotwired.dev/handbook/streams#custom-actions
d88e99c to
f8c15f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the official documentation, applications that need to extend
StreamActionsshould be importing it directly from the module instead of accessing it throughwindow.Turbo.StreamActions.This commit adds test coverage to exercise the corresponding
import. It also re-arranges theexportto explicitly occur in the@hotwired/turbomodule itself, instead of being transitively exported as part of the@hotwired/turbo/coremodule.