Why are WS/SEE not being closed after turbo-stream-source is gone?

[guillermo]

I am using Hotwired/Turbo in a go application.
On one specific page, I want to update several partials from the server asynchronously as they arrive to the server through external apis (openAI in this case).

I used this on my views:

<turbo-frame id="articles_list">
...
<turbo-stream-source src="/repurpose/{{ .ID }}/"></turbo-stream>
...
</turbo-frame>

It normally works as expected, and I can update the page nicely.

But the moment that I navigate to another page (so the turbo-stream-source gets unloaded), the ws/see connection is ignored but not closed.

turbo/src/elements/stream_source_element.ts

Lines 14 to 16 in 0826b81

	if (this.streamSource) {
	disconnectStreamSource(this.streamSource)
	}

This creates unlimited connections until I reach the browsers max, and can't navigate anymore.

I fixed it locally by modifying the source and manually closing the connection with this.streamSource.close();:

class StreamSourceElement extends HTMLElement {
...
    disconnectedCallback() {
        if (this.streamSource) {
            disconnectStreamSource(this.streamSource);
            this.streamSource.close();
        }
    }
...
}

The change seems obvious for my use case, but makes me wonder if I am using hotwire turbo as design.

Are only fixed constant connections like /cable in rails the only recommended use case?

[seanpdoyle]

Thank you for opening this issue, and for sharing your solution.

I've opened #970 to resolve it.

[kwhandy]

is this issue causing response on network tab which keep receives {"type":"ping","message":Id}, even after we move to another page which doesn't have turbo-stream-source tag in it? if yes, it's still happening right now cuz i just upgrade mine to v8 @seanpdoyle @guillermo

rails 7.1.3
turbo 8.0.0
turbo-rails 2.0.0