Add CONTRIBUTING.md #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should this be merged now? |
olivaresf
added a commit
that referenced
this pull request
Mar 1, 2024
…s-response * origin/main: Fix when snapshot cache is cleared (#185) Stale content (#184) Note feature parity in CONTRIBUTING doc Provide backwards compatibility support for Turbo 7.x and Turbolinks 5 Support visit.isPageRefresh and avoid displaying the activity indicator and screenshots when the page is refreshing Support Turbo 8 same-page refreshes and include debug logging rename loadrRequest to load (#141) Add CONTRIBUTING.md (#90) Update README window.Turbo reference (#68) # Conflicts: # Source/Session/Session.swift
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds CONTRIBUTING.md and a note to the README. I never remember the Carthage command to get the tests running locally so hopefully this will help someone.
I left the "guide" intentionally sparse as I didn't want to make too many assumptions about how Basecamp wants to manage contributor expectations.