add : test for channel component #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Darlington02
requested changes
Oct 17, 2024
| dispatcher.join_channel(channel_id); | ||
| stop_cheat_caller_address(channel_contract_address); | ||
| } | ||
|
|
There was a problem hiding this comment.
let's add an additional test to check that when a profile joins a channel, the channel NFT is minted to him
| dispatcher.leave_channel(channel_id); | ||
| stop_cheat_caller_address(channel_contract_address); | ||
| } | ||
|
|
There was a problem hiding this comment.
add an extra test to check that the channel to be left has members in the first place else it panics
| stop_cheat_caller_address(channel_contract_address); | ||
| } | ||
|
|
||
|
|
There was a problem hiding this comment.
add an extra test to check that when the profile leaves the channel, his channel nft is burnt
tests/test_channel.cairo
Outdated
|
|
||
| #[test] | ||
| #[should_panic(expected: ('Karst: not channel moderator',))] | ||
| fn test_should_panic_if_not_mod_is_removed() { |
There was a problem hiding this comment.
rename to test_should_panic_if_profile_to_be_removed_is_not_mod
tests/test_channel.cairo
Outdated
| } | ||
|
|
||
| #[test] | ||
| #[should_panic(expected: ('Karst: Not a Community Member',))] |
There was a problem hiding this comment.
this was a mistake, please use channel related error for this instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.