Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #104
Cause of the Problem
This is a bit of a detour, but the cause is that when
new Response(options)
was called in a nested manner, theoptions
referred to the same object in memory as the parent and child.So when we did
this.#res.headers.delete('content-type')
at the following location in hono, allcontent-type
s of the parent and child were deleted and theapplicatioin/json
information was lost.https://github.com/honojs/hono/blob/main/src/context.ts#L145
If the actual global.Response is passed to option when making a nested new call, the header is cloned in it process, so this problem is fixed.