feat: allow the type of app.request #1444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @hagishi ! Thanks. Looks good! Ship it. |
julianpoma
pushed a commit
to julianpoma/hono
that referenced
this pull request
Sep 16, 2023
* feat: allow the type of app.request * typo
1 task
This was referenced Dec 15, 2023
This was referenced Jan 3, 2024
This was referenced Feb 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Author should do the followings, if applicable
yarn denoifyto generate files for DenoChanges:
What this PR do?
By specifying app.request as a custom fetch, users can now write tests through app.request more efficiently while still adhering to type safety.