Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert stray fmt.Printf into logger.Printf #203

Merged
merged 1 commit into from
Oct 21, 2022
Merged

Convert stray fmt.Printf into logger.Printf #203

merged 1 commit into from
Oct 21, 2022

Conversation

glenjamin
Copy link
Contributor

Which problem is this PR solving?

  • There's a stray fmt.Printf line in transmission.go

Short description of the changes

  • I've converted it into a logger line, but I'm not sure if this is intentionally left in or not

@glenjamin glenjamin requested review from a team and JamieDanielson October 21, 2022 11:33
MikeGoldsmith
MikeGoldsmith approved these changes Oct 21, 2022
View reviewed changes
Copy link
Contributor

@MikeGoldsmith MikeGoldsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree it was accidentally missed. Thanks @glenjamin 👍🏻

@MikeGoldsmith MikeGoldsmith merged commit a25604f into honeycombio:main Oct 21, 2022
@MikeGoldsmith MikeGoldsmith added type: maintenance The necessary chores to keep the dust off. version: bump patch A PR with release-worthy changes and is backwards-compatible. version: no bump A PR with maintenance or doc changes that aren't included in a release. labels Oct 24, 2022
@MikeGoldsmith MikeGoldsmith self-assigned this Oct 24, 2022
@MikeGoldsmith MikeGoldsmith removed the version: bump patch A PR with release-worthy changes and is backwards-compatible. label Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MikeGoldsmith MikeGoldsmith MikeGoldsmith approved these changes

@JamieDanielson JamieDanielson Awaiting requested review from JamieDanielson

Assignees

@MikeGoldsmith MikeGoldsmith

Labels
type: maintenance The necessary chores to keep the dust off. version: no bump A PR with maintenance or doc changes that aren't included in a release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@glenjamin @MikeGoldsmith