Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Correct EMAThroughput math error #67

Merged
merged 1 commit into from
Jun 26, 2023
Merged

fix: Correct EMAThroughput math error #67

merged 1 commit into from
Jun 26, 2023

Conversation

kentquirk
Copy link
Contributor

Which problem is this PR solving?

  • When testing the EMAThroughput sampler, I noticed different results than I expected with longer times for AdjustmentInterval. This turned out to be a bug in the sampler's math -- a divide instead of a multiply. It got the correct result with a time of 1 second, which was the default.

Short description of the changes

  • Change / to * and fix comment.

@kentquirk kentquirk requested a review from a team as a code owner June 26, 2023 01:24
@kentquirk kentquirk merged commit 96770c8 into main Jun 26, 2023
@kentquirk kentquirk deleted the kent.fix_emathroughput branch June 26, 2023 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TylerHelmuth TylerHelmuth TylerHelmuth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kentquirk @TylerHelmuth