ci: fix releasing #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise they don't run for tagging events and then publish_github doesn't run.
Don't attach the workspace, we don't have any artifacts passed along in the workflow.
just a thought setup is implied by requiring test
|
changes look good, but it's so easy to miss things 😢 can we test with a bogus tag on your branch? |
|
I could do that again, but also that was the job that was re-run this morning. The now-deleted v0.3.0-rc6 tag was on this branch's latest commit 53aaf81. |
vreynolds
approved these changes
Dec 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
publish_githubjob.Short description of the changes
setupjob else it wouldn't run for tagging events and thereby preventpublish_githubfrom running.goexecutor instead ofgithubso we can have the make command.publish_githubafter tests pass because we shouldn't release things that could be broken!