Fix for Rails 7.2 #270
Merged
Fix for Rails 7.2 #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rails 7.2 adds a required `connection` param. This passes whatever comes in to the super method.
8c4a6e3 to
27e9f3a
Compare
|
Hey @jbennett, seems like tests are failing on Rails 7.2. Would you like to take a look? |
- `.where(user: user)` will grab the correct class/id - `if user` only filters if the user is provided, otherwise grab everything
joshuap
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rails 7.2 adds a required
connectionparam. This passes whatever comes in to the super method.