Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare 14.2.rc2 #3819

Merged
merged 6 commits into from
Jan 21, 2025
Merged

Prepare 14.2.rc2 #3819

merged 6 commits into from
Jan 21, 2025

Conversation

sairon
Copy link
Member

@sairon sairon commented Jan 21, 2025

Summary by CodeRabbit

  • New Features

    • Added support for new GPIO, PHY, and USB hub configurations in Linux kernel for AArch64 architecture
  • Updates

    • Upgraded Linux kernel version from 6.6.71 to 6.6.73 across multiple platforms and configurations
    • Updated GitHub Actions workflow Docker build action to version 6.12.0
    • Updated release candidate version from rc1 to rc2

dependabot bot and others added 6 commits January 21, 2025 22:43
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
(cherry picked from commit a9af9c8)
* buildroot 00e8f09356...ff563b383d (1):
  > Merge tag '2024.02.10' into 2024.02.x-haos

(cherry picked from commit a7cdebf)
* Enable USB-SD convertor on AMD/Xilinx Kria KD240 platform

Kria KD240 board is using SD card but SD is connected via onboard USB HUB.
USB controller is DWC3 with Xilinx glue logic. Both of these options are
enabled but board is using slg7xl45106 for driving usb-hub reset (PCA9570
driver) and USB3.0 requires initialization via PHY_XILINX_ZYNQMP driver.

All options should be enabled (=y) and can't be kernel modules because
provide access to rootfs.

* Add a note for config symbol change in 6.12

Changed in mainline commit 31e7f6c015d9eb35e77ae9868801c53ab0ff19ac

---------

Co-authored-by: Jan Čermák <sairon@users.noreply.github.com>
(cherry picked from commit 64ee535)
Build of pam_lastlog.so was disabled by updating to v1.5.3 [1] yet the line
wasn't removed from the login modules. In upstream this was resolved by adding
a config option for turning the lastlog module and dynamic disabling of the
line including it. These changes neither a fix removing the config line were
not applied to 2024.02, so cherry-pick them here to fix the issue.

* buildroot ff563b383d...3784884466 (2):
  > package/linux-pam: adjust login pam file for lastlog
  > package/linux-pam: add menuconfig option to build pam_lastlog.so

Fixes #3789

[1] https://github.com/linux-pam/linux-pam/releases/tag/v1.5.3

(cherry picked from commit af7b36e)
@sairon sairon requested a review from agners January 21, 2025 21:46
Copy link

coderabbitai bot commented Jan 21, 2025

📝 Walkthrough

Walkthrough

This pull request encompasses a comprehensive update across multiple configuration files for the Home Assistant Operating System. The primary changes include upgrading the Linux kernel version from 6.6.71 to 6.6.73 across various board-specific configurations, adding new kernel configuration options for AArch64 architecture, updating the GitHub Actions workflow Docker build action version, and incrementing the release candidate version suffix from rc1 to rc2.

Changes

File Change Summary
.github/workflows/build.yaml Updated Docker Build and Push action from v6.11.0 to v6.12.0
Documentation/kernel.md Updated kernel version to 6.6.73 for multiple boards including Open Virtual Appliance, Home Assistant Green, ODROID variants, and generic architectures
buildroot-external/board/arm-uefi/generic-aarch64/kernel.config Added new kernel configuration options: CONFIG_GPIO_PCA9570, CONFIG_PHY_XILINX_ZYNQMP, CONFIG_USB_ONBOARD_HUB
buildroot-external/configs/*_defconfig Updated Linux kernel custom version from 6.6.71 to 6.6.73 for multiple platforms (generic_aarch64, generic_x86_64, green, khadas_vim3, odroid variants, ova, tinker)
buildroot-external/meta Updated VERSION_SUFFIX from "rc1" to "rc2"

Sequence Diagram

sequenceDiagram
    participant Workflow as GitHub Actions
    participant Build as Buildroot
    participant Kernel as Linux Kernel
    
    Workflow->>Build: Trigger build with updated action version
    Build->>Kernel: Use kernel version 6.6.73
    Kernel-->>Build: Compile with new configuration options
    Build-->>Workflow: Generate system image
Loading

The sequence diagram illustrates the high-level workflow of how the updated GitHub Actions, Buildroot configuration, and Linux kernel interact during the build process.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between beafcda and 6f51b80.

📒 Files selected for processing (16)
  • .github/workflows/build.yaml (1 hunks)
  • Documentation/kernel.md (1 hunks)
  • buildroot-external/board/arm-uefi/generic-aarch64/kernel.config (1 hunks)
  • buildroot-external/configs/generic_aarch64_defconfig (1 hunks)
  • buildroot-external/configs/generic_x86_64_defconfig (1 hunks)
  • buildroot-external/configs/green_defconfig (1 hunks)
  • buildroot-external/configs/khadas_vim3_defconfig (1 hunks)
  • buildroot-external/configs/odroid_c2_defconfig (1 hunks)
  • buildroot-external/configs/odroid_c4_defconfig (1 hunks)
  • buildroot-external/configs/odroid_m1_defconfig (1 hunks)
  • buildroot-external/configs/odroid_m1s_defconfig (1 hunks)
  • buildroot-external/configs/odroid_n2_defconfig (1 hunks)
  • buildroot-external/configs/odroid_xu4_defconfig (1 hunks)
  • buildroot-external/configs/ova_defconfig (1 hunks)
  • buildroot-external/configs/tinker_defconfig (1 hunks)
  • buildroot-external/meta (1 hunks)
✅ Files skipped from review due to trivial changes (10)
  • buildroot-external/meta
  • buildroot-external/configs/khadas_vim3_defconfig
  • buildroot-external/configs/generic_x86_64_defconfig
  • buildroot-external/configs/odroid_m1_defconfig
  • buildroot-external/configs/odroid_m1s_defconfig
  • buildroot-external/configs/generic_aarch64_defconfig
  • buildroot-external/configs/tinker_defconfig
  • buildroot-external/configs/ova_defconfig
  • .github/workflows/build.yaml
  • Documentation/kernel.md
🔇 Additional comments (8)
buildroot-external/configs/odroid_c4_defconfig (1)

19-19: LGTM: Kernel version update for Odroid C4.

The kernel version update from 6.6.71 to 6.6.73 is consistent with the PR objectives and maintains compatibility with the existing v6.6.y kernel configuration fragments.

buildroot-external/configs/odroid_c2_defconfig (1)

19-19: LGTM: Kernel version update for Odroid C2.

The kernel version update from 6.6.71 to 6.6.73 is consistent with other board configurations and maintains compatibility with the existing v6.6.y kernel configuration fragments.

buildroot-external/configs/odroid_xu4_defconfig (1)

20-20: LGTM: Kernel version update for Odroid XU4.

The kernel version update from 6.6.71 to 6.6.73 is consistent with other board configurations and maintains compatibility with the existing v6.6.y kernel configuration fragments.

buildroot-external/configs/odroid_n2_defconfig (1)

19-19: LGTM: Kernel version update for Odroid N2.

The kernel version update from 6.6.71 to 6.6.73 is consistent with other board configurations and maintains compatibility with the existing v6.6.y kernel configuration fragments.

buildroot-external/configs/green_defconfig (1)

19-19: LGTM! Verify the kernel version.

The kernel version update from 6.6.71 to 6.6.73 aligns with the PR objectives.

Let's verify the kernel version exists and check for any known issues:

✅ Verification successful

✓ Kernel version 6.6.73 verified

The version is legitimate, recently released (2025-01-21), and part of the longterm support series. No critical security issues found.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the Linux kernel version 6.6.73 exists and check for any known issues.

# Check if the kernel version exists in kernel.org
curl -s https://www.kernel.org/releases.json | jq -r '.releases[] | select(.version == "6.6.73")'

# Check for any CVEs or security advisories for this kernel version
gh api graphql -f query='
{
  securityVulnerabilities(first: 5, ecosystem: LINUX, package: "linux", severity: [CRITICAL, HIGH]) {
    nodes {
      advisory {
        summary
        severity
        publishedAt
      }
      vulnerableVersionRange
      firstPatchedVersion {
        identifier
      }
    }
  }
}'

Length of output: 1948


Script:

#!/bin/bash
# Check for any CVEs or security advisories for Linux kernel
gh api graphql -f query='
{
  securityVulnerabilities(first: 5, package: "linux") {
    nodes {
      advisory {
        summary
        severity
        publishedAt
      }
      vulnerableVersionRange
      firstPatchedVersion {
        identifier
      }
    }
  }
}'

# Alternative: Check kernel.org security tracker
curl -s https://www.kernel.org/releases.json | \
  jq -r '.releases[] | select(.version | startswith("6.6.")) | "\(.version) \(.released.isodate)"'

Length of output: 485

buildroot-external/board/arm-uefi/generic-aarch64/kernel.config (3)

63-64: LGTM! Verify GPIO expander usage.

The addition of PCA9570 GPIO expander support is appropriate. Built-in configuration is suitable for essential GPIO functionality.

Let's verify if this GPIO expander is used in the codebase:

✅ Verification successful

Support for PCA9570 GPIO expander appears consistent with existing configurations

The driver is already supported as a module in the Rockchip ARM64 configuration. Building it into the kernel for generic AArch64 platform follows established patterns and has minimal impact on the system.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Search for PCA9570 references in device trees or board configs
rg -i "pca9570|gpio-expander" buildroot-external/board/

Length of output: 143


Script:

#!/bin/bash
# Broader search for PCA9570 in entire repo and documentation
echo "=== Searching entire repository ==="
rg -i "pca9570"

echo -e "\n=== Checking documentation ==="
fd -e md -e txt | xargs rg -i "pca9570|gpio.expander"

echo -e "\n=== Checking recent commits ==="
git log --grep="pca9570" --grep="gpio.expander" -i --since="6 months ago" --oneline

Length of output: 478


65-66: LGTM! PHY driver aligns with Kria KD240 support.

The addition of Xilinx ZynqMP PHY driver support aligns with the PR objective for AMD/Xilinx Kria KD240 platform support.

Let's verify the platform support:


68-70: LGTM! Track the TODO for kernel 6.12 upgrade.

The addition of onboard USB hub support aligns with the PR objective for USB-SD converter functionality. The TODO comment indicates a future configuration rename.

Let's create a tracking issue for the TODO:

Note: Would you like me to create an issue to track updating CONFIG_USB_ONBOARD_HUB to CONFIG_USB_ONBOARD_DEV when kernel 6.12 is released?


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@sairon sairon merged commit 6f51b80 into rc Jan 21, 2025
3 checks passed
@sairon sairon deleted the prepare-14.2.rc2 branch January 21, 2025 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants