Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump RPi SDIO WiFi firmware to latest version #3719

Merged
merged 1 commit into from
Dec 5, 2024
Merged

Conversation

sairon
Copy link
Member

@sairon sairon commented Dec 5, 2024

  • buildroot c65b0306bb...b2077df873 (1):

    package/brcmfmac_sdio-firmware-rpi: bump version to 4c1789e

Raspberry Pi kernel 6.6 driver for BCM43455 (used in RPi 3B+/4B) calls new API which uses the DUMP_OBSS feature for channel selection. If it's not preset, it results in drivers reporting errors, e.g.:

brcmf_set_channel: set chanspec 0xd099 fail, reason -52

The RPi OS firmware was updated but the package we use for this firmware contains an old version that lacks this support. Update to latest version synced from RPi upstream to fix the issues. The root cause is explained in [1] by @ragazenta. Both disabling the DUMP_OBSS and updating the firmware makes the errors go away.

[1] raspberrypi/linux#6049 (comment)

Fixes #3367

Summary by CodeRabbit

  • Chores
    • Updated the commit reference for a subproject in the buildroot repository.

* buildroot c65b0306bb...b2077df873 (1):
  > package/brcmfmac_sdio-firmware-rpi: bump version to 4c1789e

Raspberry Pi kernel 6.6 driver for BCM43455 (used in RPi 3B+/4B) calls new API
which uses the DUMP_OBSS feature for channel selection. If it's not preset, it
results in drivers reporting errors, e.g.:

brcmf_set_channel: set chanspec 0xd099 fail, reason -52

The RPi OS firmware was updated but the package we use for this firmware
contains an old version that lacks this support. Update to latest version
synced from RPi upstream to fix the issues. The root cause is explained in [1]
by @ragazenta. Both disabling the DUMP_OBSS and updating the firmware makes the
errors go away.

[1] raspberrypi/linux#6049 (comment)

Fixes #3367
@sairon sairon added board/raspberrypi Raspberry Pi Boards board/yellow Home Assistant Yellow wifi Wi-Fi related issues labels Dec 5, 2024
@sairon sairon requested a review from agners December 5, 2024 19:46
Copy link

coderabbitai bot commented Dec 5, 2024

📝 Walkthrough

Walkthrough

The pull request updates the commit reference for a subproject within the buildroot repository. The previous commit hash c65b0306bbae8a7018a9eaf5d5fdceb8e20de4d9 has been replaced with a new commit hash b2077df8737607aeb7f65f7508b2c577269ec15b. This change indicates a state update for the subproject without modifying any functionality or logic in the main project.

Changes

Files Change Summary
buildroot Updated subproject commit from c65b0306... to b2077df8...

Assessment against linked issues

Objective Addressed Explanation
Error Identification (3367) The changes do not address the reported error.
Operating System Details (3367) No relevant changes made for the operating system context.
Upgrade Confirmation (3367) No modifications related to upgrade confirmations.
Reproduction Steps (3367) Changes do not impact the reproduction of the issue.
Log Insights (3367) No updates provided that relate to log insights.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 4229332 and 8d61db6.

📒 Files selected for processing (1)
  • buildroot (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • buildroot

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@sairon sairon merged commit ce1e261 into dev Dec 5, 2024
3 checks passed
@sairon sairon deleted the bump-rpi-wifi-fw branch December 5, 2024 20:29
jens-maus added a commit to jens-maus/RaspberryMatic that referenced this pull request Dec 8, 2024
update the BCM43455 SDIO firmware fixing some 'brcmf_set_channel:'
errors. This refs home-assistant/operating-system#3719
This was referenced Dec 17, 2024
@lfdominguez
Copy link

On 14.1 show the same error on mi rpi4 8gb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
board/raspberrypi Raspberry Pi Boards board/yellow Home Assistant Yellow cla-signed wifi Wi-Fi related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error :" brcmfmac: brcmf_set_channel: set chanspec 0xd0...fail, reason -52 "
3 participants