Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generic-x86-64: Add support for AW-CM389MA #2815

Closed
wants to merge 1 commit into from

Conversation

WerVa
Copy link

@WerVa WerVa commented Oct 13, 2023

Support for AW-CM389MA #2783

Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @WerVa

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant home-assistant bot marked this pull request as draft October 13, 2023 19:49
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@WerVa WerVa marked this pull request as ready for review October 13, 2023 19:51
@agners agners changed the title generic-x86-64: Add missing dependency for #2783 to kernel.config generic-x86-64: Add support for AW-CM389MA Oct 17, 2023
@agners
Copy link
Member

agners commented Oct 17, 2023

@WerVa I've adjusted the title a bit. The other PR's title really missed some dependency in the kernel config, but in this case it is just a missing config option for that particular device.

I generally agree with the change. However, there is also #2761 which enables quite some firmwares as well. That PR does a bit too much at once, and brings the x86-64 image actually to its size limit.

We plan to come up with a slimmed down version of that PR, which then would also include your change. I am leaving this PR open until then.

@sairon
Copy link
Member

sairon commented Nov 30, 2023

Closing in favor of #2951.

@sairon sairon closed this Nov 30, 2023
sairon added a commit that referenced this pull request Nov 30, 2023
Preemptively enable larger set of WiFi drivers for all platforms and add more firmwares for them with the aim to harmonize WiFi device support among all boards and to have implicit support of devices that users might want to use.  Targets `generic_aarch64`, `generic_x86_64` and `ova` also include options and firmwares for cards that are using PCI/PCIe bus - support for these is in a separate config fragment.

Especially the `generic_x86_64` is currently very tight with the rootfs space, so I had to do some triaging and select only sensible drivers and firmwares - especially archaic PCMCIA devices or devices not supporting only 802.11g or lower standards were among the first that I removed during the triaging - we can consider enabling those but this time on an someone's explicit need to have them enabled.

This closes #2815 and replaces large part of #2761, also potentially addresses (at least) these: #2806, #2783, #2841, #2776, #2725, #2600

-------------

* Remove WiFi options from generic and board kernel config fragments
* Enable MMC in OVA kernel
   This is needed for SDIO drivers to work. Use the same options as we
   currently use for generic_x86_64.
* Add CRYPTO_MICHAEL_MIC to the common kernel config
   This is requirement for TKIP and is a dependency of ATH11K driver.
* Add kernel config fragments with wireless cards support
* Add firmwares for WiFi cards
* Enable more Bluetooth device drivers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants