Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Response entity is None #2944

Open
danielholm opened this issue Jan 31, 2025 · 3 comments · May be fixed by #2955
Open

Response entity is None #2944

danielholm opened this issue Jan 31, 2025 · 3 comments · May be fixed by #2955
Assignees
@larsdunemark
Labels
lang: sv

Comments

@danielholm
Copy link
Contributor

danielholm commented Jan 31, 2025 •
edited
Loading

Image

On HA 2025.2.b2.
Swedish language.

Using Voice assistant in HA to, for example, turn a light on, the response is missing entity name and simply response with

Turned on None

However turn off, shows the name
@synesthesiam
Copy link
Contributor

Is the response "Slog på None" or Tände None"?

@synesthesiam
Copy link
Contributor

In your HA, what kind of entity is "uppetoalett"?

@danielholm
Copy link
Contributor Author

The correct response for light should be "tände entity". A switch could be "slog på entity". I have a PR (not ready, for that change). Hence the response, for this example with my light uppetoalett (upstairs bathroom) should be "Slog på uppetoalett".

@danielholm danielholm linked a pull request Feb 3, 2025 that will close this issue
Draft
danielholm added a commit to danielholm/intents that referenced this issue Feb 3, 2025
@danielholm
Small response changes as for home-assistant#2944
64e3c10
larsdunemark added a commit to larsdunemark/intents that referenced this issue Feb 4, 2025
@larsdunemark
SV: Move cover from generic HassTurnOff
25faab2 
Combined redundant testcases and removed response
cover from all HassTurnOff intent.

This will probably fix one part of home-assistant#2944 where
turn off and turn on did respond with different
respond type.
larsdunemark added a commit to larsdunemark/intents that referenced this issue Feb 4, 2025
@larsdunemark
SV: Move cover from generic HassTurnOff
39c9f70 
Combined redundant testcases and removed response
cover from all HassTurnOff intent.

This will probably fix one part of home-assistant#2944 where
turn off and turn on did respond with different
respond type.
@larsdunemark larsdunemark mentioned this issue Feb 4, 2025
Merged
larsdunemark added a commit that referenced this issue Feb 4, 2025
@larsdunemark
SV: Move cover from generic HassTurnOff (#2963)
f2c3cc1 
Combined redundant testcases and removed response
cover from all HassTurnOff intent.

This will probably fix one part of #2944 where
turn off and turn on did respond with different
respond type.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@larsdunemark larsdunemark

Labels
lang: sv
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[SV] Fix #2944 - Response is None danielholm/intents
4 participants
@tetele @danielholm @synesthesiam @larsdunemark