Skip to content

Commit

Permalink
[DE] more options to cancel a timer (#2984)
Browse files Browse the repository at this point in the history
* Give more options to cancel a Timer in German

The Imperative of stopp and lösch has two viable options, with and without an e.
 
The new word option lösch(e) isn't already used in any other common option, and is German for delete. So there shouldn't be any conflicts created by this change. 

It is also a variant to cancel a timer that is allowed on Google Home and possibly Alexa (I don't have one).
Allowing it makes switching away from them easier, because you do not have to learn a now command word for the same action.

* [DE] added tests for commit 2984
  • Loading branch information
Dr4kn authored Feb 13, 2025
1 parent 5c8cc54 commit 8a16076
Show file tree
Hide file tree
Showing 3 changed files with 24 additions and 1 deletion.
2 changes: 1 addition & 1 deletion sentences/de/_common.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -598,7 +598,7 @@ expansion_rules:

# Timers
timer_set: "(starte|setze|stelle|erstelle)"
timer_cancel: "(beende|stoppe)"
timer_cancel: "(beende|stopp[e]|lösch[e])"
timer_duration_seconds: "{timer_seconds:seconds} Sekunde[n]"
timer_duration_minutes: "{timer_minutes:minutes} Minute[n][ [und]{timer_seconds:seconds} Sekunde[n]]"
timer_duration_hours: "{timer_hours:hours} Stunde[n][ [und]{timer_minutes:minutes} Minute[n]][ [und]{timer_seconds:seconds} Sekunde[n]]"
Expand Down
9 changes: 9 additions & 0 deletions tests/de/homeassistant_HassCancelAllTimers.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@ tests:
- "stoppe alle Timer"
- "stoppe sämtliche Timer"
- "stoppe alle meine Timer"
- "stopp alle meine Timer"
- "lösch alle Timer"
- "lösche sämtliche Timer"
intent:
name: HassCancelAllTimers
response: 3 Timer gestoppt.
Expand All @@ -24,6 +27,9 @@ tests:
- "stoppe im Wohnzimmer alle Timer"
- "stoppe im Wohnzimmer sämtliche Timer"
- "stoppe im Wohnzimmer alle meine Timer"
- "stopp alle Timer im Wohnzimmer"
- "lösch im Wohnzimmer sämtliche Timer"
- "lösche sämtliche Timer im Wohnzimmer"
intent:
name: HassCancelAllTimers
slots:
Expand Down Expand Up @@ -67,6 +73,9 @@ tests:
- "stoppe in diesem Raum alle Timer"
- "stoppe in diesem Raum sämtliche Timer"
- "stoppe in diesem Raum alle meine Timer"
- "stopp in diesem Raum alle Timer"
- "lösch hier alle Timer"
- "lösche in diesem Raum alle meine Timer"
intent:
name: HassCancelAllTimers
context:
Expand Down
14 changes: 14 additions & 0 deletions tests/de/homeassistant_HassCancelTimer.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,10 @@ tests:
- "beende Timer"
- "beende den Timer"
- "stoppe meinen Timer"
- "stopp den Timer"
- "lösch den Timer"
- "lösche den Timer"
- "lösche meinen Timer"
intent:
name: HassCancelTimer
response: Timer gestoppt
Expand All @@ -12,6 +16,9 @@ tests:
- "beende den 5 Minuten Timer"
- "stoppe Timer für 5 Minuten"
- "stoppe 5 Minuten Timer"
- "stopp den 5 Minuten Timer"
- "lösche Timer für 5 Minuten"
- "lösch 5 Minuten Timer"
intent:
name: HassCancelTimer
slots:
Expand All @@ -22,6 +29,9 @@ tests:
- "stoppe Pizza Timer"
- "beende meinen Pizza Timer"
- "stoppe meinen Timer für Pizza"
- "stopp den Pizza Timer"
- "lösch meinen Pizza Timer"
- "lösche Pizza Timer"
intent:
name: HassCancelTimer
slots:
Expand All @@ -32,6 +42,10 @@ tests:
- sentences:
- "beende Wohnzimmer Timer"
- "beende den Timer im Wohnzimmer"
- "lösch meinen Wohnzimmer Timer"
- "lösche meinen Timer im Wohnzimmer"
- "stopp Wohnzimmer Timer"
- "stoppe den Wohnzimmer Timer"
intent:
name: HassCancelTimer
slots:
Expand Down

0 comments on commit 8a16076

Please sign in to comment.