Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xiaomi aqara b286acn01 fix double both press #7952

Conversation

tedsluis
Copy link
Contributor

Description:

Pull request in home-assistant (if applicable): home-assistant/home-assistant# home-assistant/core#19578

Not sure how to prepare this pull request (first time for me within this project). Github says: " Can’t automatically merge. Don’t worry, you can still create the pull request."

Checklist:

  • Branch: next is for changes and new documentation that will go public with the next home-assistant release. Fixes, changes and adjustments for the current release should be created against current.
  • The documentation follows the standards.

@ghost ghost assigned syssi Dec 26, 2018
@ghost ghost added ready-for-review This PR needs to be reviewed and removed to-do labels Dec 26, 2018
@@ -33,6 +33,7 @@ The requirement is that you have setup the [`xiaomi aqara` component](/component
| Aqara Wireless Switch (Single) | 86sw1 | WXKG03LM | off (always) | `xiaomi_aqara.click` | `click_type` | `single` |
| Aqara Wireless Switch (Double) | 86sw2 | WXKG02LM | off (always) | `xiaomi_aqara.click` | `click_type` | `single`, `both` |
| Aqara Wireless Switch (Single) (2nd gen) | remote.b186acn01 | WXKG03LM | off (always) | `xiaomi_aqara.click` | `click_type` | `single`, `double`, `long` |
| Aqara Wireless Switch (Double) (2nd gen) | remote.b286acn01 | WXKG02LM | off (always) | `xiaomi_aqara.click` | `click_type` | `single`, `double`, `long`, `both`, `long_both`, `double_both` |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Could you use this order: both, double_both, long_both? Thanks in advance!

@syssi syssi merged commit 8282dbd into home-assistant:next Dec 26, 2018
@ghost ghost removed the ready-for-review This PR needs to be reviewed label Dec 26, 2018
@tedsluis tedsluis deleted the xiaomi-aqara-b286acn01-fix-double-both-press branch December 27, 2018 07:52
@frenck frenck added new-feature This PR adds documentation for a new Home Assistant feature to an existing integration next This PR goes into the next branch has-parent This PR has a parent PR in a other repo labels Dec 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has-parent This PR has a parent PR in a other repo new-feature This PR adds documentation for a new Home Assistant feature to an existing integration next This PR goes into the next branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants