Patch 1 #7926
Merged
Patch 1 #7926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I could easily and did think about it, but do you know if it is actually supported and works? I don't know that. My reason for this doc update is because the Discovery component falsely triggers an error of incorrect config when I haven't even added the config to my home assistant config. So all I've tested is adding it to discovery´s ignore to confirm that the warnings went away. And since ignore for octoprint wasn't documented I added what documentation I was sure of without having developed any part of the component. |
|
It is part of the |
based on review feedback from ludeeus.
ludeeus
approved these changes
Dec 22, 2018
alengwenus
pushed a commit
to alengwenus/home-assistant.io
that referenced
this pull request
Feb 24, 2019
* Add octoprint as possible ignore. * Added octoprint as supported component as well based on review feedback from ludeeus.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
I discovered that Discovery indeed supports ignoring octoprint as well. This is in reference to home-assistant/core#18627 but does not necessarily close that issue since this commit is just about missing documentation.
Pull request in home-assistant (if applicable): home-assistant/home-assistant#
Checklist:
nextis for changes and new documentation that will go public with the next home-assistant release. Fixes, changes and adjustments for the current release should be created againstcurrent.