Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split out HTML imports from entrypoint #6030

Merged
merged 1 commit into from
May 25, 2020
Merged

Split out HTML imports from entrypoint #6030

merged 1 commit into from
May 25, 2020

Conversation

balloob
Copy link
Member

@balloob balloob commented May 24, 2020

Breaking change

Proposed change

Part of #6028

This will no longer include the HTML import in the main entry point. It will load as soon as the main entry point has loaded. Still taking up memory but no longer delaying initial startup that much.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@@ -1,9 +1,6 @@
// Load polyfill first so HTML imports start resolving
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Someone sorted the imports at some point. The polyfill was meant to be the first import here hence the comment/eslint disable 😆

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wasn't me... 🙈 it was Organize imports

@balloob balloob force-pushed the split-html-import branch from 82127e5 to 0551b34 Compare May 25, 2020 16:51
@balloob balloob merged commit d73b3d7 into dev May 25, 2020
@balloob balloob deleted the split-html-import branch May 25, 2020 16:55
@bramkragten bramkragten mentioned this pull request Jun 3, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jul 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants