Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make part of the chart rendering async for large datasets #24260

Merged
merged 1 commit into from
Feb 18, 2025

Conversation

MindFreeze
Copy link
Contributor

@MindFreeze MindFreeze commented Feb 15, 2025

Proposed change

This releases the main thread for a bit at least. We should probably submit it as a PR to echarts so we don't have to monkey patch it but lets test it first.
Here it is based on the number of datapoints but in echarts it would be easy count the rendering time and decide dynamically whether to defer the flush.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@MindFreeze MindFreeze added this to the 2025.2 milestone Feb 15, 2025
@MindFreeze MindFreeze requested a review from wendevlin February 17, 2025 15:17
@wendevlin wendevlin merged commit c52217c into dev Feb 18, 2025
16 checks passed
@wendevlin wendevlin deleted the chart-performance branch February 18, 2025 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants