Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix energy charts with leap years #24059

Merged
merged 2 commits into from
Feb 4, 2025
Merged

Fix energy charts with leap years #24059

merged 2 commits into from
Feb 4, 2025

Conversation

MindFreeze
Copy link
Contributor

@MindFreeze MindFreeze commented Feb 4, 2025

Proposed change

This is mostly for comparing exactly 1 full year to another or comparing quarters. When using custom ranges, the data is in days and this isn't an issue.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@MindFreeze MindFreeze added this to the 2025.2 milestone Feb 4, 2025
@MindFreeze MindFreeze marked this pull request as ready for review February 4, 2025 12:20
@MindFreeze
Copy link
Contributor Author

btw If we could properly turn off data snapping for the tooltip, we could use 2 x axis instead of transforming the data but apparently it is too controversial apache/echarts#16675

@MindFreeze MindFreeze enabled auto-merge (squash) February 4, 2025 12:25
@MindFreeze MindFreeze merged commit 02ae0b5 into dev Feb 4, 2025
11 checks passed
@MindFreeze MindFreeze deleted the leap-year-chart branch February 4, 2025 12:28
bramkragten pushed a commit that referenced this pull request Feb 4, 2025
* Fix energy charts with leap years

* handle quarters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Energy Dashboard shows to small bar graphs while data comparison
2 participants