-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix sections item translation for config flow #21924
Conversation
WalkthroughWalkthroughThe changes involve modifying the Changes
Assessment against linked issues
Recent review detailsConfiguration used: CodeRabbit UI Files selected for processing (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Outside diff range, codebase verification and nitpick comments (1)
src/dialogs/config-flow/show-dialog-config-flow.ts (1)
86-86
: Approve the change but suggest adding explanatory comments.The addition of the period to the prefix is a targeted fix that addresses the translation issue described. However, it would be beneficial to add a comment explaining why this period is necessary, as it might not be immediately clear to future maintainers or contributors why this specific format is required.
+ // Append a period to ensure correct path formatting for localization keys const prefix = options?.path?.[0] ? `sections.${options.path[0]}.` : "";
Proposed change
Fixes #21887
Original PR missed a period in the path.
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed:
Summary by CodeRabbit
New Features
Bug Fixes