Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix initial theming #18296

Merged
merged 1 commit into from
Oct 20, 2023
Merged

Fix initial theming #18296

merged 1 commit into from
Oct 20, 2023

Conversation

bramkragten
Copy link
Member

Proposed change

Because load stuff later, ShadyCSS would no longer be available all the time (not a bad thing perse) so we have to handle styles ourselves when there is no ShadyCSS.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@silamon
Copy link
Contributor

silamon commented Oct 20, 2023

Tested and fixes #18291

@bramkragten bramkragten merged commit ce11301 into dev Oct 20, 2023
@bramkragten bramkragten deleted the fix-inital-theme branch October 20, 2023 18:44
@github-actions github-actions bot locked and limited conversation to collaborators Oct 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants