Add user condition to conditional card #18265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bramkragten
reviewed
Oct 23, 2023
| <mwc-list> | ||
| ${this._sortedUsers(this._users).map( | ||
| (user) => html` | ||
| <ha-list-item graphic="avatar" hasMeta noninteractive> |
There was a problem hiding this comment.
I updated to ha-check-list-item but I will look if we can have a user selector.
bramkragten
previously approved these changes
Oct 23, 2023
267c767 to
6e55ef3
Compare
6e55ef3 to
bec41fe
Compare
bramkragten
approved these changes
Oct 23, 2023
8 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Add user condition to conditional card.
Note
The editor doesn't use ha-form because we don't have user selector.
Maybe we could combine this selector (inspired from view visibility editor) with the ha-user-picker and create a, user selector (in another PR).
I will also look to move the condition validation and check into multiple files in another PRs.
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: