Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Say "log in" instead of "login" on the authorize page #18175

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

KTibow
Copy link
Contributor

@KTibow KTibow commented Oct 10, 2023

Proposed change

  • Right now we use "login" as a verb.
    image
  • While "login" is a word, it isn't proper grammar to use it this way.
  • This PR updates the authorize page's English strings to say "log in" instead.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

N/A

Additional information

N/A
I realize that the docs could refer to the previous wording, but the effort (looking through all the times it says "login" and seeing if it refers to the authorize page) isn't worth the tradeoff (not much given most users will still click on "log in" even if the docs say "login").

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

@bramkragten bramkragten merged commit b3f1783 into home-assistant:dev Oct 10, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Oct 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants